Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive grid #466

Merged
merged 24 commits into from
Feb 6, 2025
Merged

Responsive grid #466

merged 24 commits into from
Feb 6, 2025

Conversation

giannif
Copy link
Collaborator

@giannif giannif commented Jan 27, 2025

Responsive Grid:

Rewrite grid logic to support a percentageWidth, allowing the grid to be rendereded on the server.
The width property still determines the rendition selection of the grid items, but the grid will scale to the percentage value provided (e.g. 100%)

Remove useTransform property:

This was used to layout grid items and has been replaced by a new strategy

Gif:

Add lazyLoad property to Gif component, default true. If set to false, on screen logic won't be run and the img will always show. Should be used in SSR.

Loader height:

The loader style was using a padding to allow for its height, this was a bad approach as padding is not applied in flex containers.

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 18149ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@giphy/react-components Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giannif giannif force-pushed the responsive-grid-flex-cols branch from 4a3aca2 to 6df3806 Compare January 28, 2025 13:45
@giannif giannif force-pushed the responsive-grid-flex-cols branch from 6df3806 to 2dfc0f2 Compare January 28, 2025 13:56
@giannif giannif force-pushed the responsive-grid-flex-cols branch from b8ada72 to 6a36e8f Compare January 28, 2025 18:14
@giannif giannif requested a review from huntharo January 28, 2025 20:52
@giannif giannif force-pushed the responsive-grid-flex-cols branch 4 times, most recently from 633fa3f to a28288b Compare January 31, 2025 02:38
upgrade storybook / eslint
@giannif giannif force-pushed the responsive-grid-flex-cols branch from a28288b to 5076a32 Compare January 31, 2025 02:42
storybook, cypress, react-use and more
@giannif giannif force-pushed the responsive-grid-flex-cols branch from 8c5a192 to f7f319b Compare January 31, 2025 15:40
@giannif giannif force-pushed the responsive-grid-flex-cols branch from 40a3569 to c29e85f Compare January 31, 2025 18:33
@giannif giannif merged commit 0384eaf into master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant