-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono support #816
Mono support #816
Conversation
e6da25c
to
47c8787
Compare
I'm on mobile now, so this is just a guess. I can look into it further On line 56, make compilers static. private readonly ICompiler[] compilers = new ICompiler[] I vaguely remember having issues with that being static, which is why it Austin
|
Ignore me - github delivered that email notification waaaaay late :) |
@apmorton Thanks for checking in! A bit of searching and poking brought me to nunit/nunit#947 which made me realize that |
Upgraded LibGit2Sharp from version 0.22.0-pre20150716071016 to version 0.22.0 and its associated LibGit2Sharp.NativeBinaries from version 1.0.72 to version 1.0.129.
Changed usage of `Branch.Name` to `Branch.FriendlyName` and a few other properties and methods made obsolete by LibGit2Sharp v0.22.0.
Added Unix guards on the `AfterBuild` MSBuild target, so `ilmerge.exe` won't be attempted to run under Mono, where it will fail with an exit code of `126` (whatever that means).
Added reference to NUnit.Runners so we can run unit tests in the console (for Mono/Travis builds, especially).
Since `nunit3-console` is not backwards compatible with the console of NUnit 2, remove the `/noshadow` argument.
According to nunit/nunit#947, `ValueSourceAttributes` expects the referenced field to be `static` in NUnit 3.
- Upgraded LibGit2Sharp from v0.22.0 to v0.23.0-dev - Upgraded LibGit2Sharp.NativeBinaries from v1.0.129 to v1.0.137
Add a conditional on the GitVersionTask import so it's not imported on Unix, until GitTools/GitVersion#816 is fixed through a (pre-) release of libgit2/libgit2sharp#1298 on NuGet.
Add a conditional on the GitVersionTask import so it's not imported on Unix, until GitTools/GitVersion#816 is fixed through a (pre-) release of libgit2/libgit2sharp#1298 on NuGet.
Upgraded LibGit2Sharp from version 0.23.0-dev000000000000 to version 0.23.0-pre20150419160303.
Upgraded NUnit from version 3.2.0 to version 3.2.1
48b9075
to
8f5a431
Compare
Update NuGet in the Travis install step
This PR depends on GitTools/GitTools.Core#29 being merged and pre-released on NuGet so every dependency in the chain is built against LibGit2Sharp version |
Everything downstream has been merged/updated. Gonna try and push out a release, if there is any further work then we can just do a patch release :) There are other fixes I want to get out |
This PR builds on @BeeWarloc's work in #638 and fixes #264. I've added a Travis build so we can have continuous integration testing on Linux. I don't think I've broken backward compatibility with anything, so it should be safe to merge this into
master
and release as a3.x
. I think adding Linux support is so important that it can't wait for version 4.That being said, the tests on Travis fail with the following exception:
I think this is the problem being described in libgit2/libgit2sharp#1170, so when that's closed and LibGit2Sharp upgraded in this PR, Travis should happily execute the build and paint all tests in a beautiful, green color. I hope @nulltoken can verify this?
Unless libgit2/libgit2sharp#1170 takes an ice age to complete, I think merging this PR should wait until it's fixed. Oh and thanks to @gep13 for the moral support and tips on Gitter. 😄