Fix open redirect check for more cases (go-gitea#25143) (go-gitea#25154)

Backport go-gitea#25143 by @lafriks If redirect_to parameter has set value starting with `\\example.com` redirect will be created with header `Location: /\\example.com` that will redirect to example.com domain. Co-authored-by: Lauris BH <[email protected]>
GiteaBot · Jun 8, 2023 · 7679f4d · 7679f4d
1 parent 82a8c26
commit 7679f4d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/context/context_response.go b/modules/context/context_response.go
@@ -49,9 +49,9 @@ func (ctx *Context) RedirectToFirst(location ...string) {
 			continue
 		}
 
-		// Unfortunately browsers consider a redirect Location with preceding "//" and "/\" as meaning redirect to "http(s)://REST_OF_PATH"
+		// Unfortunately browsers consider a redirect Location with preceding "//", "\\" and "/\" as meaning redirect to "http(s)://REST_OF_PATH"
 		// Therefore we should ignore these redirect locations to prevent open redirects
-		if len(loc) > 1 && loc[0] == '/' && (loc[1] == '/' || loc[1] == '\\') {
+		if len(loc) > 1 && (loc[0] == '/' || loc[0] == '\\') && (loc[1] == '/' || loc[1] == '\\') {
 			continue
 		}