Skip to content

Commit

Permalink
Fix successful return value for SyncAndGetUserSpecificDiff (go-gite…
Browse files Browse the repository at this point in the history
…a#27152)

A function should not return an error when it is successful.
Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen…
  • Loading branch information
delvh authored and GiteaBot committed Sep 20, 2023
1 parent 7a99c7b commit ce55e31
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion services/gitdiff/gitdiff.go
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ outer:
}
}

return diff, err
return diff, nil
}

// CommentAsDiff returns c.Patch as *Diff
Expand Down

0 comments on commit ce55e31

Please sign in to comment.