Merge pull request #1580 from EliahKagan/msys

Append to preexisting `MSYS` env var even if ill-formed
GitoxideLabs · Sep 6, 2024 · d00235a · d00235a
2 parents 93e86f1 + c38d9b9
commit d00235a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tests/tools/src/lib.rs b/tests/tools/src/lib.rs
@@ -593,8 +593,8 @@ fn configure_command<'a>(
     args: &[String],
     script_result_directory: &Path,
 ) -> &'a mut std::process::Command {
-    let mut msys_for_git_bash_on_windows = std::env::var("MSYS").unwrap_or_default();
-    msys_for_git_bash_on_windows.push_str(" winsymlinks:nativestrict");
+    let mut msys_for_git_bash_on_windows = std::env::var_os("MSYS").unwrap_or_default();
+    msys_for_git_bash_on_windows.push(" winsymlinks:nativestrict");
     cmd.args(args)
         .stdout(std::process::Stdio::piped())
         .stderr(std::process::Stdio::piped())