Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures #221

Closed
FintanH opened this issue Oct 15, 2021 · 3 comments
Closed

Build failures #221

FintanH opened this issue Oct 15, 2021 · 3 comments

Comments

@FintanH
Copy link
Contributor

FintanH commented Oct 15, 2021

Hey @Byron 👋

Seems like there's some funkiness going on with building some of the gitoxide crates. The build failed here, and I can reproduce it locally by trying to build radicle-link/librad on the xla/seen branch.

Does it seem like the problem is internal to gitoxide rather than something radiclel-link is doing? Let me know if I can help in any way =]

@Byron
Copy link
Member

Byron commented Oct 15, 2021

Oh no, so sorry for that. I was quite confident that nothing can break because I used cargo smart-release and it safety-bumped a bunch of crates which should prevent such thing from happening.

Apparently, that wasn't the case or it wasn't enough.

Tomorrow I will dig right into it and submit a PR for a fix.

Looking at the build failures, it does look like cargo tree -v git-hash would report multiple git-hash versions to be pulled in (which is exactly what shouldn't even be possible). Maybe cargo update will already do the trick, but if not… all I would do is to see align all versions once again which might involve upgrading everything to the latest version. It's so strange though, as I would think that all my publishes today where minor upgrades, hence cargo shouldn't pull these in.

@Byron
Copy link
Member

Byron commented Oct 16, 2021

I found the issue that might have caused this breakage, see #222.

Byron added a commit that referenced this issue Oct 16, 2021
Byron added a commit that referenced this issue Oct 16, 2021
Byron added a commit that referenced this issue Oct 16, 2021
…-publishes… (#221)

…which isn't testing that safety-bumped crates in dependencies are
always released as well.
@Byron
Copy link
Member

Byron commented Oct 20, 2021

Will be fixed with radicle-dev/radicle-link#791 .

@Byron Byron closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants