Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gix-config] Run parse::tests::section::size_of_events only on 64 bit architectures #1337

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

blinxen
Copy link
Contributor

@blinxen blinxen commented Apr 5, 2024

The problem with parse::tests::section::size_of_events is that assumes that the test is always run on a 64 bit architectures. This PR simply disables the test on non 64 bit architectures. I am unsure if you want this kind of problem to be handled like this. What would be your (@Byron) desired behavior in this case?

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

For background, there was a fuzzer test which genuinely managed to make the memory consumption go incredibly high, which led to monitoring the size of this data structure.
It should be enough to keep an eye on it on a single known platform, as it will be indicative to others as well, while being easier to maintain.

@Byron Byron merged commit 52efa90 into GitoxideLabs:main Apr 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants