Refactor: Make it easier to compile gitoxide as dynlib #1384
+36
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also optimize compilation time: By making
plumbing
andporcelain
as modules thelib.rs
, they can be compiled after the rmeta for the dependencies are generated.For the
uni.rs
which uses bothplumbing
andporcelain
, this would avoid compiling these two modules twice.This PR would also help @holzschu 's use case.
With this PR merged and published to https://crates.io , you can compile gitoxide as a dynlib using:
Cargo.toml
:in
src/lib.rs
:Then you would have a C dynlib, with two C API in it:
gix_main
andein_main