In gix-testtools, use ignore and index via gix_worktree
#1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `gix-ignore` and `gix-index` direct dependencies of `gix-testtools`, by having `gix_testtools` use them through `gix-worktree`, accessing `gix_worktree::ignore` for `gix_ignore` and `gix_worktree::index` for `gix_index`. The rationale is that various other gix-* dependencies were used this way already, and also that this specific change appears to have been planned, based on the TODO comment in ddaacda (GitoxideLabs#1413).
This comment was marked as resolved.
This comment was marked as resolved.
Byron
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
gix-ignoreandgix-indexdirect dependencies ofgix-testtools, by havinggix_testtoolsuse them throughgix-worktree, accessinggix_worktree::ignoreforgix_ignoreandgix_worktree::indexforgix_index.The rationale is that various other
gix-*dependencies were used this way already, and also that this specific change appears to have been planned, based on the TODO comment in ddaacda (#1413).Just in case this were to have unanticipated ramifications, I've rerun the full test suite, after
gix clean -xde, both with and withoutGIX_TESTS_IGNORE_ARCHIVES=1, locally on Ubuntu 22.04 LTS and Windows 10.(On Windows 10 without using pre-generated archives, there are failures, but the failures are the same as in #1358 and #1358 (comment) in this gist, indicating that the changes in this PR have not broken Windows either.)