Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worktrees of submodules now know their correct worktree #1762

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

Byron
Copy link
Member

@Byron Byron commented Jan 12, 2025

Previously they would use a very incorrect worktree which would cause the status to be calculated very wrongly.

Fixes #1759 .

Tasks

  • reproduce the issue
  • fix it

Byron added 2 commits January 12, 2025 11:02
Previously they would use a very incorrect worktree which would cause
the status to be calculated very wrongly.
…rktrees.

Excluding the main worktree which isn't always present.
@Byron Byron force-pushed the fix-1759 branch 2 times, most recently from 9186fa0 to 87938bb Compare January 12, 2025 12:48
That way clippy will allow to use the fantastic `Option::is_some_and()`
and friends.
@Byron Byron merged commit 7ec21bb into main Jan 12, 2025
20 checks passed
@Byron Byron deleted the fix-1759 branch January 12, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect work_dir for worktrees of submodules
1 participant