BREAKING: remove lean cli variant #218
Conversation
caspervonb
force-pushed
the
breaking-remove-lean-variants
branch
from
c49fa19 to
db1fd37
Compare
| @@ -53,7 +51,6 @@ pretty-cli = ["clap", | |||
| "gitoxide-core/local-time-support", | |||
| "env_logger", | |||
| "futures-lite"] | |||
| lean-cli = ["argh", "prodash/progress-log", "env_logger" ] | |||
There was a problem hiding this comment.
I think it should be easier to rename lean-cli into something like lean-progress and leave all features but argh, which is replaced with clap. Maybe lean-cli could even stay as a name, but without argh.
| res | ||
| } | ||
| }); | ||
| // LIMITATION: This will hang if the thread panics as no message is send and the renderer thread will wait forever. |
There was a problem hiding this comment.
I have the feeling this comment is (sigh) out of date, catch unwind is actually used further down which resolves the panic issue described here.
|
Maybe the untangling will be helped with this document, a doc about all available features or how they are intended. |
|
Punting for now, I want to reduce the number of overall variants. Will get back to this. |
Let's get back to this together, feature flags here are quite a beast by now and since I know their intend beyond documentation, doing so will probably speed up getting to a PR that can be merged. |
(WIP, need to untangle the feature flags a bit)
Towards #215