Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case-insensitive file systems (those that apply folding rules) #341

Merged
merged 19 commits into from
Mar 2, 2022
Merged

handle case-insensitive file systems (those that apply folding rules) #341

merged 19 commits into from
Mar 2, 2022

Conversation

Byron
Copy link
Member

@Byron Byron commented Feb 24, 2022 •
edited
Loading

Tasks

  • make sure it's clear the current implementation is only good for 'clone' mode due to many missing checks, probably with a mode enum.
  • checkstat and trustctime property - probably an fs feature
  • single-threaded collision reporting

@Byron Byron mentioned this pull request Feb 24, 2022
Open
44 tasks
@Byron Byron changed the title detect issues with case-insensitive file systems (those that apply folding rules) and handle multi-threading correctly. handle case-insensitive file systems (those that apply folding rules) Feb 24, 2022
@Byron Byron force-pushed the checkout-collisions branch 3 times, most recently from 23405aa to 28bb4a3 Compare March 2, 2022 05:38
Byron added 19 commits March 2, 2022 14:03
@Byron
refactor (#301)
004394a
@Byron
sketch filesystem context, without probing for now (#301)
de3749e
@Byron
Support for 'serde1' feature in git-worktree (#301)
f11929c
@Byron
document-features support for git-index and git-worktree (#301)
1367cf5
@Byron
refactor for checkout to use fs::Context (#301)
8914fcc 
The latter should be useful when fully implementing all required
baseline capabilities of doing a correct checkout
@Byron
make clear that we are currently only dealing with checkout during cl…
178beb4 
…one (#301)
@Byron
symlink probing (#301)
1bfbf1d
@Byron
basic test for filesystem probing (#301)
adbed12
@Byron
determine filesystem case (#301)
f8e1de0
@Byron
refactor (#301)
fc816bd
@Byron
probe precompose unicode (#301)
0c1c006
@Byron
thanks clippy
3229240
@Byron
support for executable bit check (#301)
267e3a7
@Byron
validate that colliding files are checked out (#301)
09fecd9
@Byron
refactor: remove unnecessary unsafe by using chunks_mut()
9b9f10a 
This was probably a left-over from times where there was a static
requirement on the chunks processing. Maybe… .
@Byron
Add check_stat and trust_ctime options to index checkout (#301)
1a502c7 
For now they are unused but that should change when doing collision
checks.
@Byron
finally an understanding on collision checking (#301)
0454e4a 
Let's not try to imitate git here but instead solve the problem our
way while learning from bugs git ran into in the process.

This will be particularly interesting when dealing with parallel
checkouts, something we need to implement for sure.

On the bright side, there seems to be opportunity for a performance
boost due to less iops during clone.
@Byron
try to fix windows (#301)
5c1e727
@Byron
speed up git-pack testing on windows (#301)
8ca400c 
It takes more than 60 seconds to run this test, which is odd but for
now it seems ok to just dial down the numbers a little.
@Byron Byron force-pushed the checkout-collisions branch from 28bb4a3 to 8ca400c Compare March 2, 2022 06:03
@Byron Byron merged commit 8ca400c into main Mar 2, 2022
@Byron Byron deleted the checkout-collisions branch March 2, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Byron