Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials helper launching in all its variety #496

Merged
merged 244 commits into from
Sep 5, 2022
Merged

Credentials helper launching in all its variety #496

merged 244 commits into from
Sep 5, 2022

Conversation

Byron
Copy link
Member

@Byron Byron commented Aug 22, 2022 •
edited
Loading

Tasks

  • consider protocol.*.allow
  • credentials
    • support helper functions (instead of programs) no need, only interesting for testing actually
    • git-command to spawn commands 'git-style' and eventually also hooks, somewhat similar to run-command.c.
    • support for custom credential helper programs and usage of the credential.helper configuration (via git-sec)
    • credentials context
    • custom credential helper programs and test
    • custom prompts via git-prompt
      • askpass
      • proper prompts
      • an expectrl driven test
  • configuration of credential-helpers with url-based config.
    • empty string clears list
    • url normalization to not stumble over trailing slashes (minimal, probably not as complete)
    • useHttpPath
    • patterns in the domain
    • case-sensitivity
    • username (if not provided by the url we matched against)
  • find a way to not use hardcoded defaults. Do it by injecting a global configuration file based on git invocations.
    - on MacOS /usr/bin/git the 'system' config is scope 'unknown' and would need to be parsed via -l --show-origin and the first line is the path. '--system' is not present. On windows, --system works as expected and these count as installation directory.
  • support overriding the credentials helper (while allowing it to launch the built-in one) with a custom function
  • take another look at the tests skipped on linux
  • gix remote refs for non-symbolic remote, like in PR checkouts
  • gix credential as equivalent to git credential, just for fun

Next PR

  • filter remote refs by ref-spec and provide information on which local refs would be updated (TBD next)
  • refactor: git-sec remove tag from Access, make a check that only returns on Option, ignoring Deny.

Out of scope

  • proxy support
  • mirror support
  • All information related to pushing
  • promisor objects
  • branch.<name>.merge support, as we don't yet merge anything and fetching still fetches the entire refspec of as configured in the remote.

Predecessor

Byron added 30 commits August 22, 2022 21:45
@Byron
Support for -c CLI config overrides in gix config. (#450)
19c1746 
It's special as it creates its own repository.
@Byron
feat!: generalize extension schemes. (#450)
96a265c 
Previously this was hard-coded to `radicle`, now it's just an extension
scheme along with a statically known string. This means we have to
explicitly support new formats which should be fine.
@Byron
adjust to changes in git-url (#450)
bb83843
@Byron
tests for protocol.allow (#450)
cd59965
@Byron
sketch for lazy initialization of information to deal with allowing s…
3f708f3 
…chemes (#450)
@Byron
support for failing configuration, for now without 'lenient' config s…
2bce6a3 
…upport (#450)

No leniency because it's hard to decide what to do, allowing connections
is probably not it, so better fail with the correct error message.
@Byron
feat: Scheme::try_from(&str) (#450)
d40f6e1
@Byron
The first succeeding test for allowing schemes (without 'user' settin…
3ec28f0 
…g) (#450)
@Byron
thanks clippy
c5bd452
@Byron
fix!: make Scheme work with serde, removing Copy in the process. e#…
2da6c86 
…450)

This wasn't supposed to happen but a requirement to get `serde` support
back.
@Byron
deal with changes in git-url (#450)
6f89659
@Byron
thanks clippy
dc74fbd
@Byron
Respect permissions.allow (#450)
f8a5188
@Byron
update README to reflect new gix remote refs command (#450)
0f18ff5
@Byron
Merge branch 'main' into filter-refs-by-spec
cfa1440
@Byron
refactor (#450)
a395308
@Byron
rename!: helper::(encode|decode)_message(…) to `::message::(encode|…
4c39521 
…decode)(…)` (#450)
@Byron
change!: hide helper::action() in favor of single path via `helper(…
081934c 
…)` (#450)
@Byron
change!: use thiserror instead of quickerror (#450)
4c1a1a2
@Byron
re-add Result type (#450)
de92fce 
It's actually used and useful.
@Byron
fix docs (#450)
db46b60
@Byron
refactor (#450)
167b521 
align usage of stdin and stdout to factor it elsewhere.
@Byron
prepare for more additional implementations of helpers (#450)
486ef98
@Byron
refactor (#450)
af27d20
@Byron
feat: helper::invoke(helper, action, context) function that allows …
64bc2ec 
…for more flexible helper invocation (#450)
@Byron
express helper() in terms of helper::invoke() (#450)
f2a2c5e
@Byron
refactor (#450)
077ab57 
avoid using actual credentials helper where none is required
@Byron
thanks clippy
01efe88
@Byron
refactor (#450)
03bf747
@Byron
change!: move helper::invoke() related types into helper::invoke …
71f6519 
…module. (#450)

Also allow to pass arbitrary bytes (more or less) as context by not
forcing it all into a string. Values can now be everything, which
helps with passing paths or other values.
Byron added 23 commits September 3, 2022 14:07
@Byron
fix: Reference::remote() can produce remotes for URLs (#450)
74ede20
@Byron
remark about improvements to the type system around certain remote na…
a872bf7 
…mes. (#450)

Have to represent names or urls seprately or risk this to be a hazard
for any caller.
@Byron
thanks clippy
82ee79e
@Byron
Merge branch 'main' into filter-refs-by-spec
1f6e5ab
@Byron
refactor (#450)
93ac4c3
@Byron
feat!: Add reference remote name type to make usage of `remote_name()…
2992b1b 
…` result clear (#450)
@Byron
thanks clippy
34bc1b3
@Byron
Merge branch 'main' into filter-refs-by-spec
9aa1d3d 
Conflicts:
	cargo-smart-release/Cargo.toml
	experiments/diffing/Cargo.toml
	experiments/object-access/Cargo.toml
	experiments/traversal/Cargo.toml
	git-attributes/Cargo.toml
	git-config/Cargo.toml
	git-odb/Cargo.toml
	git-pack/Cargo.toml
	git-ref/Cargo.toml
	git-repository/Cargo.toml
	git-url/Cargo.toml
	gitoxide-core/Cargo.toml
@Byron
feat: protocol::Context::to_bstring(), and use it in `example/git-c…
15f1afc 
…redential-lite` (#450)
@Byron
feat: add prompt to top level forwarding #450)
1c13f11
@Byron
Add sketch of gix credential (#450)
642e21f 
Needs integration with Repo configuration, which includes prompt
options actually.
@Byron
program::main::Action::as_str() (#450)
d95029e
@Byron
refactor (#450)
7abc0a3
@Byron
Mention gix credential program (#450)
4dbbf51
@Byron
Also provide prompt configuration to allow Cascade::invoke() to be ca…
5b4cb83 
…lled with all arguments (#450)
@Byron
fix exports to allow error type to be visible publicly (#450)
b978619
@Byron
Use repository configuration for calling credential helper (#450)
8e07784
@Byron
first step towards efficiently obtaining git config information (#450)
cc78473
@Byron
A way to parse the first git-config file path (#450)
ea52e4e
@Byron
remove quick-error in favor of thiserror (#450)
ea84e62
@Byron
feat: Add permissions::Config::git_binary field (#450)
d51e7c9 
When true, default false, inject the git installation configuration file
if present at the cost of one `git config` invocation.

Note that we rely on the underlying `git-config` crate to not load
duplicate files.

We also currently lie about the scope which is actually unclear - have
seen 'unknown' or normal scopes like `system`.
@Byron
Select gix commands will now load the git installation configuration (
23d2dec 
#450)

This is important as it may contain additional credential helper
configuration that we definitely need to find the credentials that
git usually finds.
@Byron
thanks clippy
ab81525
@Byron Byron merged commit 5c05198 into main Sep 5, 2022
@Byron Byron deleted the filter-refs-by-spec branch September 5, 2022 11:00
This was referenced Sep 5, 2022
Merged
Merged
@Byron Byron mentioned this pull request Sep 16, 2022
Merged
8 tasks
@EliahKagan EliahKagan mentioned this pull request Oct 24, 2024
Merged
@EliahKagan EliahKagan mentioned this pull request Feb 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Byron