bare `clone` for `git-repository` #551

Byron · 2022-10-05T07:30:29Z

Cloning is essentially initializing a new repository, adding a remote, and fetching the pack based on the standard refspecs.

There are some subtleties with local clones for instance that are to be validated - maybe these are happening naturally as they are typical for tests.

It will be interesting to figure out an API that can work without having to pass massive Options structures just to pre-fill methods that are called later, as such it's OK to be more low-level at first to one day get a 'one method call' counterpart with common options.

Tasks

a way to write a remote's configuration back to a file (even though this one can be special as there is no prior configuration to pay attention to during clone).
API sketch, allow for later addition of recursive cloning of submodules and worktree checkouts, and for configuring configuration and credentials, and open options
respect all applicable configuration variables
validate this part of the fetch docs - is it true? It doesn't look like it when checking the code, but let's note this as difference in our implementation, which doesn't special case force anywhere.

Unlike when pushing with git-push[1], any updates outside of refs/{tags,heads}/* will be accepted without + in the refspec (or --force), whether that’s swapping e.g. a tree object for a blob, or a commit for another commit that’s doesn’t have the previous commit as an ancestor etc.

Out of scope

submodules

For now without any handling of removing previous values.

…y named section. We also add `File::remove_section_by_id()` to make it possible to remove specific sections.

…d mutate them. As section names are not unique, it was previously not possible to iterate sections and then mutate them as one wouldn't be able to refer to the exact section that was just traversed, after all, there can be many sections named `remote "origin"`. With the new methods it's possible to uniquely refer to each section for mutation and removal.

Previously, newlines would remain past a value, and whitespace could remain before one. Now both are removed to simulate removing an actual line.

Much better whitespace handling definitely shows here.

It also showed that we aren't quite lossless with our urls yet.

Previously a url like `/path/to/repo` would serialize to `file:///path/to/repo`, preventing round-trips. Now it serializes like it was parsed. This also means that `file://path` still serializes as `file://path`.

Previously `git@host:path` would turn into `ssh://git@host/path`, which now remains exactly as is.

…tantiation.

It's explicitly a multi-step process and maybe the function names could represent that better.

…realize that subsection/remote-name validation is incorrect here and in another place that needs fixing.

It can be useful to validate subsection names without having to construct an entire `Header` (which also includes a name).

…n't handled correctly yet

…tances instead That lifetime unnecessarily complicated things and wasn't worth keeping due to being a premature optimization.

…orktree

Byron mentioned this pull request Oct 5, 2022

Fetch and clone support (bare) #450

Open

27 tasks

Byron changed the title ~~fetch pack for clone~~ clone for git-repository Oct 5, 2022

Byron changed the title ~~clone for git-repository~~ bare clone for git-repository Oct 5, 2022

Byron added 27 commits October 5, 2022 15:27

checkboxes for upcoming bare clone capability

0135532

layout save API for remotes

50fbcca

thanks clippy

1cba50f

Merge branch 'main' into clone

acb0738

A basic save_to() implementation for url and push-url

e1f7c5f

For now without any handling of removing previous values.

improve clarity docs related to mutating sections

769e897

test another prerequisite

1375368

save all data we currently use on a Remote

79a4952

fix: File::remove_section() was fixed to allow re-adding a similarl…

e533993

…y named section. We also add `File::remove_section_by_id()` to make it possible to remove specific sections.

remove prior existing values for remotes before saving

4126d99

thanks clippy

d82a08d

assure unrelated and unwritten keys are not touched

ca5bb5e

fix: greatly improve whitespace handling when removing values.

9c1e639

Previously, newlines would remain past a value, and whitespace could remain before one. Now both are removed to simulate removing an actual line.

adapt to changes in git-config

058473d

Much better whitespace handling definitely shows here.

add test to assert on lossless saving of existing named remotes

884b6e9

It also showed that we aren't quite lossless with our urls yet.

feat: lossless serialization of file urls.

58a6000

Previously a url like `/path/to/repo` would serialize to `file:///path/to/repo`, preventing round-trips. Now it serializes like it was parsed. This also means that `file://path` still serializes as `file://path`.

feat: (mostly) lossless roundtripping of scp-like urls.

39ce98b

Previously `git@host:path` would turn into `ssh://git@host/path`, which now remains exactly as is.

more assurance we understand how relative paths in scp-like urls work

5926322

adjust to changes in git-url

a1068a3

feat: Url::try_from(path: &std::path::Path) for more convenient ins…

22d3b37

…tantiation.

Api sketch to show how clones and bare clones can be done.

ef1e783

It's explicitly a multi-step process and maybe the function names could represent that better.

refactor

d7f495d

sketch a way to configure remotes

615a3a9

start adding support for naming the remote, but…

6cbea96

…realize that subsection/remote-name validation is incorrect here and in another place that needs fixing.

thanks clippy

8c8fba2

feat: add parse::section::header::is_valid_subsection() function.

aa5d66f

It can be useful to validate subsection names without having to construct an entire `Header` (which also includes a name).

Byron added 16 commits October 9, 2022 21:16

Another test to validate components must not be empty

b2c9af1

properly validate remotes when instantiating them and when naming them

1fb97fb

make it possible to renmae the remote

3f8b0e5

thanks clippy

f65a1f4

sketch and test for clone::Prepare::fetch_only()

f993cd4

update progress with intended uses of clone. variables

8b804a3

Complete implementation of fetch_only, even though configuration is…

b0f5836

…n't handled correctly yet

the first successful test for cloning a bare repository

5ecc965

update usage of clone related configuration

1a1e862

thanks clippy

bc2710f

change!: remove lifetime of match_group::Fix, keeping RefSpec ins…

2a0a87a

…tances instead That lifetime unnecessarily complicated things and wasn't worth keeping due to being a premature optimization.

adjust to changes in git-refspec

c62f37a

validate the outcome of the fetch as well

3865aea

validate default remote name as well and show minimal clone without w…

dff66e8

…orktree

fix build

314b5e0

fix docs

4474352

Byron mentioned this pull request Oct 10, 2022

worktree checkout for clone and gix integration #555

Merged

18 tasks

Byron merged commit 507dc7e into main Oct 10, 2022

Byron deleted the clone branch October 10, 2022 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bare `clone` for `git-repository` #551

bare `clone` for `git-repository` #551

Byron commented Oct 5, 2022 •

edited

Loading

bare clone for git-repository #551

bare clone for git-repository #551

Conversation

Byron commented Oct 5, 2022 • edited Loading

Tasks

Out of scope

bare `clone` for `git-repository` #551

bare `clone` for `git-repository` #551

Byron commented Oct 5, 2022 •

edited

Loading