Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Archiving campaigns #2462

Open
MoeNick opened this issue Aug 10, 2021 · 15 comments
Open

Archiving campaigns #2462

MoeNick opened this issue Aug 10, 2021 · 15 comments
Assignees
Labels
feature request All issues that require new implementations

Comments

@MoeNick
Copy link
Member

MoeNick commented Aug 10, 2021

https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6

aminlatifi pushed a commit to Giveth/feathers-giveth that referenced this issue Aug 15, 2021
aminlatifi pushed a commit to Giveth/feathers-giveth that referenced this issue Aug 15, 2021
aminlatifi pushed a commit to Giveth/feathers-giveth that referenced this issue Aug 15, 2021
aminlatifi pushed a commit to Giveth/feathers-giveth that referenced this issue Aug 15, 2021
@mohammadranjbarz mohammadranjbarz self-assigned this Aug 18, 2021
@mohammadranjbarz mohammadranjbarz added the feature request All issues that require new implementations label Aug 18, 2021
@mohammadranjbarz
Copy link
Collaborator

@MoeNick
we said we should not let anyone to edit archived campaign, do we allow to Cancel archived campaign or not?

@MoeNick
Copy link
Member Author

MoeNick commented Aug 18, 2021

I think we can ban cancelling, and let the owner to undo archiving and then able to cancel it. @mohammadranjbarz

@mohammadranjbarz
Copy link
Collaborator

I think we can ban cancelling, and let the owner to undo archiving and then able to cancel it. @mohammadranjbarz

@MoeNick
Is it a final decision or just a suggestion?
I think we should now allow campaign owner to unArchive, because if in some case for some reason admin archive campaign, but campaign owner can undo that,
Maybe it's better to don't allow to edit archived campaign, or unArchive that, but it's ok to cancel that

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Aug 19, 2021

@RamRamez
plz read https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6
we add a Archived status

  • you should show a button to Admins and campaign owner to can Archive the campaign (Active campaigns could archive),
  • If a campaign is archived don't show edit button for that ( backend would not allow to edit that)
  • you should not show donate/delegate button for campaigns with status ( you can search disableDonate in your code, it's similar our case)
  • you should not show donate/delegate button for trace, if parent campaign of that trace has Archived status
  • Should show an unArchive button (@MoeNick what should be the text of button?) to admins and campaign owner

PS : for archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Archived'}
PS2: for undo archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Active'}

mohammadranjbarz added a commit to Giveth/feathers-giveth that referenced this issue Aug 21, 2021
@mohammadranjbarz
Copy link
Collaborator

@RamRamez
plz read https://www.notion.so/giveth/Archived-Campaigns-6a074d87bdc14f0795195f4d6cea8ec6
we add a Archived status

  • you should show a button to Admins and campaign owner to can Archive the campaign (Active campaigns could archive),
  • If a campaign is archived don't show edit button for that ( backend would not allow to edit that)
  • you should not show donate/delegate button for campaigns with status ( you can search disableDonate in your code, it's similar our case)
  • you should not show donate/delegate button for trace, if parent campaign of that trace has Archived status
  • Should show an unArchive button (@MoeNick what should be the text of button?) to admins and campaign owner

PS : for archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Archived'}
PS2: for undo archiving campaigns you should call /campaigns/{campaignId} PATCH and in body send {status:'Active'}

@RamRamez This comment has been edited, please let me know if you had any question.

@RamRamez RamRamez self-assigned this Aug 23, 2021
@MoeNick
Copy link
Member Author

MoeNick commented Aug 24, 2021

Text at the top of achieved campaign: "This campaign is archived. It no longer accepts funds."
Text at the top of traces with achieved campaign: "Due to [campaign name] campaign is archived, This Trace no longer accepts funds."
Text for button: "Archive" - "Unarchive"
Note: **a pop up needed for approving archive. as we have it in deleting or cancelling, needs 5 characters. **
Text of pop-up:
"Archiving Campaign? {as title}
By archiving this campaigns, it won't get listed and nobody can donate or delegate funds to it, nor its traces.
Are you sure you want to archive this Campaign? Please enter the first 5 characters (without space) of the Campaign title while skipping any spaces:
[Text Box] "

@MoeNick
Copy link
Member Author

MoeNick commented Aug 24, 2021

@WhyldWanderer appreciate if you can confirm the wording and grammar of the above ^^
@RamRamez : FYI

@WhyldWanderer
Copy link
Collaborator

WhyldWanderer commented Aug 30, 2021

My suggestions:
Text at the top of archived campaign: "This campaign is archived and no longer accepts funds."
Text at the top of traces under archived campaign: "Because [campaign name] campaign is archived, this Trace no longer accepts donations."
Text for button: "Archive" - "Unarchive"
Text of pop-up:
"Archiving Campaign? {as title}
By archiving this campaign, it will no longer be listed and will be unable to accept future donations or delegations. Any TRACES listed under this campaign will be archived as well. Would you like to proceed?"
If you are sure you want to archive this Campaign, please enter the first 5 characters (without spaces) of the Campaign title.
[Text Box] "

RamRamez added a commit that referenced this issue Aug 31, 2021
@MoeNick
Copy link
Member Author

MoeNick commented Sep 5, 2021

Error msg over delegating to parent archived trace:
{Campaign Name} Campaign is archived. You can't delegate to this campaign nor its Traces.

@MoeNick
Copy link
Member Author

MoeNick commented Sep 5, 2021

I made another issue and move this to done.

@MoeNick
Copy link
Member Author

MoeNick commented Oct 14, 2021

@mohammadranjbarz @RamRamez
Admin can archive and unarchive
Campaign Owner should only archive

@RamRamez
Copy link
Collaborator

@MoeNick

Please send me the new message that we are gonna show when user Archive/UnArchive.

image

@RamRamez
Copy link
Collaborator

And this is UnArchive message:

image

@MoeNick
Copy link
Member Author

MoeNick commented Oct 14, 2021

Are you sure you want to archive this campaign? It can be reactive again by Giveth Admin only. @RamRamez

@WhyldWanderer
Copy link
Collaborator

image

Should say:
"Archive Campaign?
By archiving this campaign, it will no longer be listed and will be unable to accept future donations or delegations. Any TRACES listed under this Campaign will be archived as well. This action can only be reversed by an a Giveth admin.
Would you like to proceed?"

RamRamez added a commit that referenced this issue Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request All issues that require new implementations
Projects
None yet
Development

No branches or pull requests

4 participants