-
Notifications
You must be signed in to change notification settings - Fork 229
Donate by simply sending to an address with a standard transaction fee #478
Comments
The first task is just to write up the smart contract, and the tests for the smart contract that can receive funds and the only thing it can do is donate to the Giveth DApp to a specific DAC (For now it will be the Giveth DAC). The factory doesn't need to be written, this is only a proof of concept, but it should also be seen as a learning exercise in writing SAFE smart contracts that start off with centralizing security features, that can be removed once the code is trusted (Start off safe with a path to decentralization). The video above gives the general design pretty well. To add to it I would say start with the Bridge contract as a base so you can have the owned, escapable, pausable, and ERC20 standard contracts in place as these are best practices. Also it is the contract that must receive the funds from the contract that you create: Bridge Contracts: https://github.com/Giveth/giveth-bridge/tree/master/contracts This will be a fun, simple contract. Great for someone who has been working with solidity for over 2 months, but under 6 months. To complete this bounty it will have to be deployed to Ropsten and work for donating to our Ropsten-Rinkeby bridge. Completing this bounty will probably require a couple conversations, please message me on riot: @GriffGreen:matrix.org or give me another method to reach out. Suggested reward 1 ETH (and developing skills) |
(requested from gitcoin) |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund__.__
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 6 months, 4 weeks from now. 1) sameer2800 has been approved to start work. I would like to take this task.I have been reading giveETH docs as well as bridge smart contracts. Learn more on the Gitcoin Issue Details page. 2) vimalanand has applied to start work (Funders only: approve worker | reject worker). Hello, I am front-end developer. I would like to make things easier for the end-user. I have only worked for e-Commerce applications so far. Would like to get an opportunity to learn and implement a solution for Web 3.0 payments. Learn more on the Gitcoin Issue Details page. |
@sameer2800 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot , here it is : Giveth/collection-box#1 |
fyi this needs some thought of how to handle when the bridge is replaced. You'll need to either freeze the contract, or be able to update the pointer to the bridge. But the campaign/dac owner should not be able to update the bridge address as then they could take the funds w/o ever going through the dapp. It probably makes sense to use the upgreadability of aragonOS (or maybe there is a more lightweight upgreadability solution (zepplin?)), or possibly just point to another contract to fetch the current bridge address, so that the giveth multisig can update the bridge location w/o breaking these deployed contracts. |
Hi @GriffGreen, is it good to pay out bounty to @sameer2800 or is there a bit more work to be done on this repo? Thanks! |
Nope! We are still working on it! |
@perissology I agree very much. The Aragon App will be the way forward in the long run. I am just looking to whip out a fast POC that i can play with so we can discover the unknown needs :D |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by: @mkosowsk please take a look at the submitted work:
|
yep its done now @mkosowsk :-D |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @sameer2800.
|
#433 is similar |
We NEED this! So bad! |
Since this issue is still open, keep in mind that graceaid.eth is now registered! |
just passing here to create (more ?) awareness about the need of this feature to be deployed!! I would like to create a payment from an smart contract (e.g an Aragon DAO finance app) directly to a milestone, so there's no passing through the UI here. let's take this milestone as an example. When looking for its ethereum address I discover by attempting to make the donation via UI the sollowing addres: https://etherscan.io/address/0x30f938fed5de6e06a9a7cd2ac3517131c317b1e7 but it doen't has correspondency to the status of the milestone funds |
a couple background links Giveth/giveth-bridge#9 |
Working on it!! |
@dapplion @arbreton and @aminlatifi are looking into integrating it now :-D |
Generate funds forwarder, person send money to an address, created funds forwarder sends money to the bridge |
1.Someone needs to trigger the generation of the fund forwarder from the campaign page... so the address is known. |
Is this implemented? |
The goal is to make donating as easy as possible.
Right now every donation to any DAC, Campaign, or Milestone requires a user to include Data and the transaction fee is higher then a standard transaction.
The end goal of this issue would be an easy user experience for donating using simply an ENS (or RSK equivalent) name.... and ideally it would use the same gas as a normal transaction.
For instance, what if you could donate directly to graceaid.campaign.eth without having to include any data in the transaction, or pay more then 21000 gas and the information would all be passed to the contract as needed to trace the donation so that if they ever wanted to come back and use the platform, they could see EXACTLY where their donation went.
This would mean, if Andreas was on a podcast, he could just say "Support us by donating to graceaid.campaign.eth" and then anyone with any wallet and any level of technical expertise could donate to his campaign with ease!
I will make a video explaining a possible solution, but this is just my design on how this end goal could be achieved... its a bit of a rant and for sure is a serious undertaking... but it could be done in stages :-D
The text was updated successfully, but these errors were encountered: