Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Create a donation address option (Feature request) #446

Closed
GriffGreen opened this issue Jul 25, 2018 · 3 comments
Closed

Create a donation address option (Feature request) #446

GriffGreen opened this issue Jul 25, 2018 · 3 comments
Labels
feature request All issues that require new implementations

Comments

@GriffGreen
Copy link
Member

Can i put a bounty on part or all of this?

Tension:
You can't donate to anything by simply sending to an address.

Proposal:

I would like for there to be a button that would allow any DAC, campaign, or milestone to create an anon donation address.

I have a proposed smart contract design:

Create a factory that deploys a contract for every project when this button is pushed

That contract is a very simple contract with

  1. Payable fallback function to receive money
  2. sendAnonDonation() function that anyone can push. The Giver is 0x0 (does that have a GiverID :-D?)
  3. escapeHatch and all that escape hatch destination being the giveth multisig, escape hatch caller, the owner of the project(Delegate, milestone manager, campaign manager)

We should track this feature in the dapp and maintain a list of these deployed contracts and probably even canceling a campaign or milestone require the reviewer to call the sendAnonDonation()

---questions----

It would be nice if it is a donation to a DAC that we could skip the 3 day waiting period.

The hard part of course is making the UX/UI inside of the dapp. that i have no advice for.
@vojtechsimetka
Copy link
Collaborator

We are actually discussing feature request strategy as a financing model for the DApp. As for the idea I think we can talk about it, maybe there is an easy and cheap solution.

@vojtechsimetka vojtechsimetka added the feature request All issues that require new implementations label Jul 26, 2018
@GriffGreen GriffGreen mentioned this issue Jul 29, 2018
Closed
vojtechsimetka added a commit that referenced this issue Jul 29, 2018
@vojtechsimetka
Actually fixing #446...
f09f58c
vojtechsimetka added a commit that referenced this issue Aug 4, 2018
@vojtechsimetka
Merge branch 'develop' into release
25b29ff 
* develop: (29 commits)
  Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address.
  Fixes #386
  This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet).
  Fixes #401
  Fixes #442
  closes #383 update web3 version
  Fixed type error
  remove item.etherAmount
  simplify profile view, only show mileste users, not addys
  fix DonateButton bug if user cancels tx
  Add check for wallet balance in refund
  Remove text confirmation while cancelling milestone
  Add package-lock
  rm package-lock.json
  Refactor
  Actually fixing #446...
  Fixes #448
  Improve delete milestone confirmation
  Improve refund donation confirmation
  Improve cancel milestone confirmation
  ...
vojtechsimetka added a commit that referenced this issue Aug 5, 2018
@vojtechsimetka
Merge branch 'develop' into feature/ga
c7af39b 
* develop: (25 commits)
  Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address.
  Fixes #386
  This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet).
  Fixes #401
  Fixes #442
  closes #383 update web3 version
  Fixed type error
  remove item.etherAmount
  simplify profile view, only show mileste users, not addys
  fix DonateButton bug if user cancels tx
  Add check for wallet balance in refund
  Remove text confirmation while cancelling milestone
  Add package-lock
  rm package-lock.json
  Refactor
  Actually fixing #446...
  Fixes #448
  Improve delete milestone confirmation
  Improve refund donation confirmation
  Improve cancel milestone confirmation
  ...

# Conflicts:
#	src/components/views/MyCampaigns.jsx
vojtechsimetka added a commit that referenced this issue Aug 6, 2018
@vojtechsimetka
Merge branch 'release'
3321f4c 
* release: (33 commits)
  Allows unregistered users to donate (but displays warning).
  Fixing GA linter issues.
  Removed the prefilled recipient address. This might be prefilled as a metamask address but should not stay DApp address.
  tracking events and pageviews
  tracking events and pageviews
  Fixes #386
  This whole thing should be rewritten but for the time being it is unlikely that some milestones will be hidden in the delegate button (the service returns latest 100 that are in progress and has not been fully funded yet).
  Fixes #401
  Fixes #442
  closes #383 update web3 version
  Fixed type error
  remove item.etherAmount
  simplify profile view, only show mileste users, not addys
  fix DonateButton bug if user cancels tx
  Add check for wallet balance in refund
  Remove text confirmation while cancelling milestone
  Add package-lock
  rm package-lock.json
  Refactor
  Actually fixing #446...
  ...
@ewingrj
Copy link
Contributor

ewingrj commented Aug 9, 2018

relevant comment: #145 (comment)

@vojtechsimetka
Copy link
Collaborator

Duplicate of #478

@vojtechsimetka vojtechsimetka marked this as a duplicate of #478 Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature request All issues that require new implementations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vojtechsimetka @GriffGreen @ewingrj