GIVpower Boosting | Exclude deactivated projects from ranking calculations

[laurenluz]

@mohammadranjbarz - we should exclude the deactivated projects from ranking calculations. The should keep their GIVpower on them (because they might keep the verified status), but should not come up in the ranking order.

[mohammadranjbarz]

@MoeNick @maryjaf
It's on Staging , you can test it

[maryjaf]

When I deactivate the project, the rank and boost option are not displayed correctly in the project details and as before, the deactivate project is not displayed on the project page
But I have a question. I deactivated the project at 18:12. The ranking was like this

After a few minutes, it changed according to the picture
This is true?current and projected rank? @mohammadranjbarz @laurenluz

https://giveconomy.vercel.app/project/mejan

[maryjaf]

one general question about boosting and projected rank,
Is it accepted that when the givpower of one of the project changes or one project deactivate or un-verify or every change about boosting and rank, Expected Rank(Projected Rank) for all projects change to "--"until next snapshot or round
@laurenluz @mohammadranjbarz @aminlatifi

[laurenluz]

if a project is deactivated, it should have current rank "--" and projected rank "--" right away... until it is reactivated. @MohammadPCh @mohammadranjbarz cc @maryjaf

Is it accepted that when the givpower of one of the project changes or one project deactivate or un-verify or every change about boosting and rank, Expected Rank(Projected Rank) for all projects change to "--"until next snapshot or round

The expected rank of all projects shouldn't become "--" just because one gets deactivated. We should just exclude the one deactivated (or cancelled or unverified) project from our calculations... so every other project that was ranked below it might move up one rank. @maryjaf

[mohammadranjbarz]

@laurenluz @maryjaf

1. Now I changed it to update raning immediately after activate/deactivate
2. @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last
3. I couldn't reproduce the bug that Maryam said , deactivate/activate project doesn't affect other project's rankings , but @maryjaf if you see that happens we can have a quick call to find the cause ( I couldn't reproduce the bug)

[maryjaf]

• @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last

Thanks @mohammadranjbarz @MohammadPCh I tesed and the first problem about showing last rank in projected rank has been solved and changed to "--"
and the second scenario I couldn't reproduce it and it seems has been resolved

[maryjaf]

• @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last

Thanks @mohammadranjbarz @MohammadPCh I tesed and the first problem about showing last rank in projected rank has been solved and changed to "--"
and the second scenario I couldn't reproduce it and it seems has been resolved

[maryjaf]

• @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last

Thanks @mohammadranjbarz @MohammadPCh I tesed and the first problem about showing last rank in projected rank has been solved and changed to "--" and the second scenario I couldn't reproduce it and it seems has been resolved

In re-testing, I noticed that sometimes this problem still occurs that the last rank is displayed for the deactivated project.
After activating and deactivating once, it was fixed
@MohammadPCh

[CarlosQ96]

@maryjaf was this a project who's last rank was like that before Mohammad's fix or can you reproduce it still?

I think it's because since he changed migrations and code, some things might be fixed when done NOW, but old data remained the same.

[maryjaf]

• @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last

Thanks @mohammadranjbarz @MohammadPCh I tesed and the first problem about showing last rank in projected rank has been solved and changed to "--" and the second scenario I couldn't reproduce it and it seems has been resolved

In re-testing, I noticed that sometimes this problem still occurs that the last rank is displayed for the deactivated project. After activating and deactivating once, it was fixed @MohammadPCh

[laurenluz]

@MohammadPCh is this fixed now?

@maryjaf - can you retest?

[maryjaf]

• @MohammadPCh fixed the issue of showing future rank when totalPower is 0 and rank is the last

The second item happend again
I deactivate a project (alirezatest)and I expected that projected rank changed to "--" but in this example changed into "26"

@mohammadranjbarz @MohammadPCh

[maryjaf]

Thanks @MohammadPCh this problem has been resolved