Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Cancelled Status in Projects (managed only by admins. ) #245

Open
laurenluz opened this issue Sep 15, 2021 · 11 comments
Open

Cancelled Status in Projects (managed only by admins. ) #245

laurenluz opened this issue Sep 15, 2021 · 11 comments
Assignees

Comments

@laurenluz
Copy link
Member

laurenluz commented Sep 15, 2021

Me as a Giveth Admin want to add "cancelled" project status, its different with di-activation or activation which is made by Project Owner. We cancel some project because violates out terms and conditions.
So:

1- Only admins can make it cancelled and it can ONLY revert it to active state .
2- Cancelled should not be listed, and not be accessible through the project's URL
3- They can be shown in user's "my project" but with some indication that it was cancelled by an admin
4- Mutations
5- Segment changes

#33 #67

@RamRamez
Copy link
Collaborator

RamRamez commented Oct 2, 2021

@laurenluz Are admin cancelled projects different from project owner cancelled projects?

@MoeNick
Copy link
Member

MoeNick commented Oct 3, 2021

@laurenluz what will happen after cancelling by admin?
I think in a "cancelled" project status:
1- not being listed
2- can be showed in user dashboard to PO, but PO cant edit or do certain activities like activation or deactivating.
3- visible by users if they have direct url, but a badge showing this project is cancelled and no longer receive donation.
4- not being able to recieve hearts or updates nor donations.
5- Only Admin can revert it to active state.

Am I right?

@laurenluz
Copy link
Member Author

hmm almost @MoeNick but a few differences... I think the cancelled projects should:
1- not be listed, and not be accessible through the project's URL
2- can be shown in user's "my project" but with some indication that it was cancelled by an admin
3- only admin can revert it to active state OR after a period of time the project is completely deleted from the db

The only reason we would "cancel" a project is if it violates out terms and conditions... doing things like publishing others' private information, threatening violent, posting inappropriate photos, etc.

@RamRamez yeah the admin cancelled should be different from PO cancelled projects... basically if the PO cancels their own project, they should be able to reactivate it. However, with the admin cancelled projects, the PO should NOT be allowed to reactivate it... only an admin could do so.

@MoeNick MoeNick changed the title Ensure that cancelled projects cannot be reactivated by the project owner Cancelled Status in Projects (managed only by admins. ) Oct 15, 2021
@MoeNick
Copy link
Member

MoeNick commented Oct 18, 2021

@mateodaza would pls add related front end issues?

@mateodaza
Copy link
Member

@mateodaza would pls add related front end issues?

Just met with Carlos, we are going to use one of the status that is already on database called "deleted" for this use case.

We'll follow this case scenario, thanks @laurenluz

@mohammadranjbarz
Copy link
Collaborator

You can test this issue now but it's better to stay for implementing
#340

@divine-comedian
Copy link
Contributor

divine-comedian commented Nov 23, 2021

testing on next.giveth.io

I can cancel projects on the adminBro dashboard, this changes their status to delisted

when I go to the project's page it does not let me interact with it, the page is blurred out and a popup modal says the project is deactivated.

as the project owner I am prevented from activating this project and a notification tells me I do not have permission.

an event is sent to segment - Project cancelled

this mostly looks good but I might have mentioned it in another issue if we could change the notification text for when a user tries to reactivate their project. It should give them some more precise information -

"This project has been cancelled by an Admin for inappropriate content or a violation of our Terms of Use. You have received an email containing more information."

@CarlosQ96

@CarlosQ96
Copy link

@divine-comedian I'll be renaming the admin bro and the statuses so it's explicit what they are. But the last message you mention is more on the frontend side, it doesn't touch the backend. @mateodaza

@divine-comedian
Copy link
Contributor

it's actually in the impact-graph the notification text - under projectResolver

        throw new Error(
          'User does not have permission to update status on that project',
        );

I'll just go ahead and change it but maybe double check that the error logic makes sense that it only triggers in the case of a project owner trying to reactivate a cancelled project

@CarlosQ96
Copy link

Oh ok, Got it. I thought we had another message on the frontend. Sure the exception message can be changed. @divine-comedian

@divine-comedian
Copy link
Contributor

okay the text has been updated correctly on staging - moving to done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants