Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add admin canceled project status #177

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

CarlosQ96
Copy link
Collaborator

@CarlosQ96 CarlosQ96 commented Oct 24, 2021

This PR begins using the status 7 called Delisted already in our db.
This status means the Admin cancelled a project and only said admin can activate it again, not the project owner.
Also added a class to notify segment of project updates that will be sent when updating the project from the index view in the adminbro, or editing the project individually.

Removed the "Project edited" segment call @divine-comedian on the editProject mutation as this will be called in the AfterUpdate callback in the project entity.

To test this PR you can enter de adminbro an call the actions on the bluebar:
image

Finally you can also test the "Project edited" segment call by editing the project individually in the adminbro or calling the following mutation (edit it as you need):
mutation { editProject(projectId: 1, newProjectData: { title: "test" }) { id } }

Result (ignore project deleted, I renamed it as cancelled):

image

If you could do some testing @divine-comedian and @laurenluz that would be awesome. Remember to change to my branch and run the impact graph.

@CarlosQ96 CarlosQ96 force-pushed the feature/allow_admin_canceled_projects branch 2 times, most recently from 08c80e5 to 8df5b78 Compare October 25, 2021 01:57
@CarlosQ96
Copy link
Collaborator Author

We should discuss tomorrow how to rename the statuses I feel they are a bit over-engineered and now it's confusing.

@CarlosQ96 CarlosQ96 force-pushed the feature/allow_admin_canceled_projects branch from 8df5b78 to 30e2df9 Compare October 25, 2021 02:12
@mohammadranjbarz
Copy link
Collaborator

related to Giveth/giveth-next#245

Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlosQ96 Nice work
Seems good to me,
you did a great job especially for refactoring Segment stuff

@mohammadranjbarz
Copy link
Collaborator

This PR always resolves #152

@mohammadranjbarz mohammadranjbarz merged commit f9f4917 into staging Oct 25, 2021
@aminlatifi aminlatifi deleted the feature/allow_admin_canceled_projects branch January 25, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants