Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejecting/Verifying Project verification forms are not triggering email #624

Closed
CarlosQ96 opened this issue Sep 6, 2022 · 11 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@CarlosQ96
Copy link
Collaborator

Reported by Nikola.

Revoking on the old buttons in the projects page work.

But the new verification flow it does not.

@CarlosQ96 CarlosQ96 added the bug Something isn't working label Sep 6, 2022
@CarlosQ96
Copy link
Collaborator Author

image
image
Both reject and verify are not sending the email

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 8, 2022

Screen Shot 1401-06-17 at 11 48 40

Screen Shot 1401-06-17 at 11 48 48

@CarlosQ96 As I checked the segment logs I saw we send events, but I checked the auto pilot and understood we don't have any journey for Project rejected so it makes sense why we don't send email for this specific event, I would change the code to send Project unverified event in this case

@mohammadranjbarz
Copy link
Collaborator

Can you guys test it? @NikolaCreatrix @CarlosQ96
It's on production now

@NikolaCreatrix
Copy link

Hi @CarlosQ96 and @mohammadranjbarz and fyi @WhyldWanderer

I just tested with google chrome these actions:

  1. Rejecting from the list of projects - trigger email - works

image

  1. Rejecting from the project card - triggers email - works
    image

  2. Verify from the project card when previously Rejected - changes the status but doesn't trigger email (we need this change also to trigger email sometimes we do that action)

  3. Verify from the project card when submitted - doesn't trigger the email, does change the status

image

@mohammadranjbarz
Copy link
Collaborator

Hi @CarlosQ96 and @mohammadranjbarz and fyi @WhyldWanderer

I just tested with google chrome these actions:

  1. Rejecting from the list of projects - trigger email - works

image

  1. Rejecting from the project card - triggers email - works
    image
  2. Verify from the project card when previously Rejected - changes the status but doesn't trigger email (we need this change also to trigger email sometimes we do that action)
  3. Verify from the project card when submitted - doesn't trigger the email, does change the status

image

Thanks @NikolaCreatrix For your information, I would check it again

@NikolaCreatrix
Copy link

Still only 'verifying' doesn't trigger email. Tested again just now.

@mohammadranjbarz mohammadranjbarz changed the title Rejecting Projects is not triggering email Rejecting/Verifying Project verification forms are not triggering email Sep 20, 2022
@mohammadranjbarz
Copy link
Collaborator

Still only 'verifying' doesn't trigger email. Tested again just now.

I read the codes again, logic is correct, just tested it again and I received the email, I will coordinate with you in DM to check it together in a call to see what happens, maybe it goes to your spam,

Screen Shot 1401-06-29 at 10 16 10

And below screenshot is the related segment event

Screen Shot 1401-06-29 at 10 19 56

@MoeNick
Copy link
Member

MoeNick commented Oct 9, 2022

@mohammadranjbarz did you contact @NikolaCreatrix ?
Do you want me to ask @maryjaf to test it on production?

@mohammadranjbarz
Copy link
Collaborator

@mohammadranjbarz did you contact @NikolaCreatrix ? Do you want me to ask @maryjaf to test it on production?

It would be good

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 9, 2022

Please create production access for me @MoeNick

@NikolaCreatrix
Copy link

Hi guys, according to last week triggering both email responses works okay now. Thank for your amazing detective work and support.

@MoeNick MoeNick closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants