Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Admin Column that was Deprecated #825

Closed
CarlosQ96 opened this issue Jan 25, 2023 · 8 comments
Closed

Remove Admin Column that was Deprecated #825

CarlosQ96 opened this issue Jan 25, 2023 · 8 comments

Comments

@CarlosQ96
Copy link
Collaborator

We had issues with admin column as it was a string, we couldn't fetch relationships effectively.

I deprecated for new endpoints this column, and created AdminUserId column with foreign keys so we can work better with relations.

However we can remove the old "Admin" column yet. Old tests and old code that hasn't been updated still use it.

Lets remove admin column!

@CarlosQ96 CarlosQ96 self-assigned this Jan 25, 2023
@MoeNick
Copy link
Member

MoeNick commented Jun 13, 2023

tagging @WhyldWanderer here to prioritise

@RamRamez
Copy link
Collaborator

@maryjaf to test an verify
It's just a code refactor but for testing it's good to test general use cases related to Admin actions like the toast notifications for givback and verified projects on owner and non owner view, also actions like editing a project from project view that's related to admin actions

@maryjaf
Copy link
Collaborator

maryjaf commented May 20, 2024

  • 1-
    There is a problem in showing verification status in project page, "incomplete","submitted,"rejected " aren't shown correctly in project page, it seems there only two statuses , verified and not verified

for example for "Incomplete" verification status in project owner view, the status should be shown"Incomplete" and "resume verification" button , please take a look

Correct view on production
image

Current View on STG
image
image

@maryjaf
Copy link
Collaborator

maryjaf commented May 20, 2024

  • 2-
    There is no reason for deactivating
    image

@maryjaf
Copy link
Collaborator

maryjaf commented May 20, 2024

It's just a code refactor but for testing it's good to test general use cases related to Admin actions like the toast notifications for givback and verified projects on owner and non owner view, also actions like editing a project from project view that's related to admin actions

-I haven't seen any problem in project edit flow from admin panel and toast box for givback eligible or not eligible tokens in donate page

@divine-comedian
Copy link
Collaborator

@maryjaf - can we call this issue done then?

@RamRamez
Copy link
Collaborator

  • 2-
    There is no reason for deactivating
    image

I think it was a temporary problem, I tested and it was ok for me.

@RamRamez
Copy link
Collaborator

RamRamez commented May 20, 2024

  • 1-
    There is a problem in showing verification status in project page, "incomplete","submitted,"rejected " aren't shown correctly in project page, it seems there only two statuses , verified and not verified

for example for "Incomplete" verification status in project owner view, the status should be shown"Incomplete" and "resume verification" button , please take a look

Correct view on production image

Current View on STG image image

I fixed this problem. My PR just got approved and I merged it. @maryjaf you can test it after the build is completed (20 minutes from now)

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from New Issues to Done in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged to Production
Development

No branches or pull requests

5 participants