-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Admin Column that was Deprecated #825
Comments
tagging @WhyldWanderer here to prioritise |
@maryjaf to test an verify |
for example for "Incomplete" verification status in project owner view, the status should be shown"Incomplete" and "resume verification" button , please take a look |
-I haven't seen any problem in project edit flow from admin panel and toast box for givback eligible or not eligible tokens in donate page |
@maryjaf - can we call this issue done then? |
I fixed this problem. My PR just got approved and I merged it. @maryjaf you can test it after the build is completed (20 minutes from now) |
We had issues with admin column as it was a string, we couldn't fetch relationships effectively.
I deprecated for new endpoints this column, and created AdminUserId column with foreign keys so we can work better with relations.
However we can remove the old "Admin" column yet. Old tests and old code that hasn't been updated still use it.
Lets remove admin column!
The text was updated successfully, but these errors were encountered: