Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitcoin adapter for integration #1006

Merged
merged 6 commits into from
May 29, 2023
Merged

Add gitcoin adapter for integration #1006

merged 6 commits into from
May 29, 2023

Conversation

CarlosQ96
Copy link
Collaborator

@CarlosQ96 CarlosQ96 commented May 22, 2023 •
edited
Loading

Related to: #987

@CarlosQ96 CarlosQ96 changed the base branch from staging to f_980_implement_qfRound May 28, 2023 05:33
@CarlosQ96 CarlosQ96 changed the title Add gitcoin adapter for integration (wip) Add gitcoin adapter for integration May 28, 2023
@CarlosQ96
Copy link
Collaborator Author

CarlosQ96 commented May 28, 2023 •
edited
Loading

When you can review and merge Mohammad to your branch, you can use the gitcoin api.

@CarlosQ96 CarlosQ96 marked this pull request as ready for review May 28, 2023 06:56
@CarlosQ96
Copy link
Collaborator Author

CarlosQ96 commented May 28, 2023 •
edited
Loading

You can get the api keys by following the beginning of this guide https://docs.passport.gitcoin.co/building-with-passport/quick-start-guide
The registration of the passport is a bit tricky im not sure if the frontend implemented the auth for it yet. But i merged Amin's Pr to staging/develop of the authe microservice for passport submitting and nonce generation

@CarlosQ96 CarlosQ96 force-pushed the feature_qf_integration branch from c54a93a to fa1d7dc Compare May 28, 2023 07:09
@CarlosQ96
Copy link
Collaborator Author

Endpoint Definition which I based the interfaces off: https://docs.passport.gitcoin.co/building-with-passport/scorer-api/endpoint-definition

@CarlosQ96
Copy link
Collaborator Author

CarlosQ96 commented May 28, 2023 •
edited
Loading

I tested manually the api and error results and data, but the test is for the query functionality mostly.

mohammadranjbarz
mohammadranjbarz approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CarlosQ96 LGTM

@mohammadranjbarz mohammadranjbarz merged commit 2ea6958 into f_980_implement_qfRound May 29, 2023
@aminlatifi aminlatifi deleted the feature_qf_integration branch February 13, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosQ96 @mohammadranjbarz