Feature add optimism goerli network #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosQ96
force-pushed
the
feature_add_optimism_goerli_network
branch
from
39b92d2 to
fb0c94f
Compare
CarlosQ96
force-pushed
the
feature_add_optimism_goerli_network
branch
3 times, most recently
from
5ca0b4e to
5a420d8
Compare
CarlosQ96
force-pushed
the
feature_add_optimism_goerli_network
branch
from
fb038f2 to
7b95681
Compare
CarlosQ96
force-pushed
the
feature_add_optimism_goerli_network
branch
from
7b95681 to
d5933ed
Compare
Comment on lines
+10
to
+18
| await queryRunner.manager.save( | ||
| Token, | ||
| seedTokens | ||
| .filter(token => token.networkId === NETWORK_IDS.OPTIMISM_GOERLI) | ||
| .map(t => { | ||
| t.address = t.address?.toLowerCase(); | ||
| return t; | ||
| }), | ||
| ); |
There was a problem hiding this comment.
I think you need to add a condition to not add these test tokens in production env
mohammadranjbarz
requested changes
Jun 25, 2023
There was a problem hiding this comment.
Thanks @CarlosQ96 , except comment that I put in migrations file other things seems good to me
|
Thanks Mohammad addded the condition to not add them in production |
mohammadranjbarz
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1036