Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont allow edit qfRound after it ends #1042

Merged

Conversation

mohammadranjbarz
Copy link
Collaborator

related to #998 (comment)

When trying to edit a qfround that it's endDate has passed we show this error
Screen Shot 1402-04-11 at 16 58 14

Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@maryjaf
Copy link
Collaborator

maryjaf commented Jul 3, 2023

plz let me know when it is ready to test @CarlosQ96

@mohammadranjbarz mohammadranjbarz merged commit c70d3a0 into staging Jul 4, 2023
@mohammadranjbarz mohammadranjbarz deleted the f_998_dont_allow_edit_qf_round_after_it_ends branch July 4, 2023 05:36
@mohammadranjbarz
Copy link
Collaborator Author

plz let me know when it is ready to test @CarlosQ96

@maryjaf Now it's on Staging, you can test it

@maryjaf
Copy link
Collaborator

maryjaf commented Jul 5, 2023

plz let me know when it is ready to test @CarlosQ96

@maryjaf Now it's on Staging, you can test it

This issue has been resolved, Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants