-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
651 run migration files as js file #1604
Conversation
… environment name
…g migrations js files
WalkthroughThe recent changes streamline the migration scripts for different environments by adjusting the paths and commands for running and reverting migrations. Specifically, the scripts now use compiled JavaScript files in production and TypeScript files in other environments. Additionally, the configuration file Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Developer
participant Package.json
participant Ormconfig.ts
participant TypeORM
Developer->>Package.json: Run migration script
Package.json->>TypeORM: Execute migration command with environment-specific path
TypeORM->>Ormconfig.ts: Load configuration
Ormconfig.ts->>TypeORM: Provide environment-specific migration settings
TypeORM->>Database: Run or revert migrations
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- package.json (1 hunks)
- src/ormconfig.ts (2 hunks)
Additional context used
Biome
src/ormconfig.ts
[error] 42-44: A global variable should not be reassigned. (lint/suspicious/noGlobalAssign)
Assigning to a global variable can override essential functionality.
Additional comments not posted (3)
src/ormconfig.ts (1)
23-23
: The import ofENVIRONMENTS
is correctly placed and necessary for the conditional logic below.package.json (2)
212-212
: The updated migration run script correctly points to the JavaScript configuration file and uses thetypeorm
CLI directly, aligning with the PR objectives.
213-213
: The updated migration revert script is consistent with the migration run script and correctly uses the JavaScript configuration file.
Revert "651 run migration files as js file (#1604)"
* Change for Project Ownship * i have fixed the issue for transfer project ownership in adminBro and fixed for eslint * Revert "651 run migration files as js file (#1604)" This reverts commit 5140a93. * Update staging-pipeline.yml * Update staging-pipeline.yml * Update staging-pipeline.yml * Create funding.json * Fix issue in db migration scripts (#1608) * Change commands to use typeorm cli * Select migration files based on node env * Fix eslint errors on staging branch * add cache to mainCategories query * add cache to findQfRounds query * add cache to findQfRounds query * fix MainCategory test case * removed unnecessary comments and changed email to admin id * fix: filter unique donors based on passport score and knownAsSybilAddress * set cache duration as env var * allow refresh concurrently of materialized views (#1611) * add logger to updateProjectStatistics * fix: add new field isDataAnalysisDone to QF Round * fix: refactor condition where data analysis shouldn't be edited * fix: issue while listing recurrring donations * revert concurrent flag for failed views * fix: requested change (using subquery to get unique donors count) * add getUserAnalysisScore * revert all materialized views concurrent flag * reactivate concurrent flag for all materialized views * move refresh estimated matching view last * Add some error logs and complete some error messages (#1623) * move refreshProjectEstimatedMatchingView * fix: retrieve correct usd value of donations for an archived QF round * skip if there's a wrong tx hash * skip if there's a wrong error in insertDonationsFromQfRoundHistory * Get giv price from coingecko instead of subgraph (#1621) * Get giv price from coingecko instead of subgraph related to Giveth/giveth-dapps-v2#4168 * Fix linter errors * Remove poignArt stuff * remove unused logs * remove unused logs * force findActiveQfRound to use read replica * rewrite updateProjectStatistics * move refreshProjectEstimatedMatchingView * optimize updateProjectStatistics * ProjectEstimatedMatchingView V3 * resolve ProjectEstimatedMatchingView V2 errors * update donationRepository.test.ts * update donationRepository.ts * update project.ts * update ProjectEstimatedMatchingView.ts * update projectRepository.ts * update projectService.ts with new estimated matching structure * update qfRoundHistory.ts with new estimated matching structure * update qfRoundRepository.test.ts with new estimated matching structure * update qfRoundRepository.ts with new estimated matching structure * update qfRoundResolver.ts with new estimated matching structure * update qfUtils.ts with new estimated matching structure * add verified status * add minimumPassportScore to getProjectQfRoundStats * add check for begin and end date to getProjectQfRoundStats * remove refreshProjectEstimatedMatchingView from tests * fix qfRoundRepository.test.ts tests * remove qfRound stats from projects when added or removed from QF round * update added projects only * update added projects only * optimize refreshProjectEstimatedMatchingView * set NODE_ENV for refreshProjectEstimatedMatchingView * merge getQfRoundUniqueDonors and getQfRoundTotalDonations * fix adding valueUsd to query * add userQfRoundModelScore * remove minimumPassportScore from getProjectQfRoundStats * remove user join from getProjectQfRoundStats * remove insertDonationsFromQfRoundHistory from syncDonationStatusWithBlockchainNetwork * enable replica * projectVerificationRepository.ts replace .save with update method * projectVerificationRepository.ts replace .save with update method * remove unused fields from logs * remove user from badge warning * optimize projectsWithoutUpdateAfterTimeFrame * Zkevm integration (#1635) * Integrate with zkevm chain related to #1617 #1615 #1618 #1619 #1614 #1620 * Add coingeckoId for wbtc zkevm token * Fix lint errors * Remove duplicate keys in provider.ts * Fix AAve token on zkevm chain * fix merge conflicts * add projectId to projectRepository.ts * remove unnecessary updatedAt * fix: get unique_donors based on user wallet address not added to sybil table * add cache to findActiveQfRound * Add on conflicrt do nothing for add zkevm tokens * Fix add polygon zkevm token migration * remove updateTotalDonationsOfProject from migrations * replace updateTotalDonationsOfProject with updateProjectStatistics * replace updateTotalDonationsOfProject with updateProjectStatistics * remove sumDonationValueUsd from project * do email verification on project verification form through Ortto * add solana to available networks for qfround * remove knownAsSybilAddress from user * wrong query cache in some functions * User Story - Rejected project owner reason * use networkId instead of optimism-only flag (#1653) * Use networkId instead of optimismOnly flag * Update graphql queries for tests * fatal errors (#1640) * change critical error logs to fatal * add fatal log for donation verification failure with time threshold * added on final step for verification project data * Replace ortto External Embedded Webform for Onboarding guide * fix: findArchivedQfRounds query * fix subscribeOnboarding args * change output to boolean * WIP: add API key to request & add fetch MBD score record from DB * fixed last step verification * fixed typo * WIP: add field to user that holds user MBD score for an active round * disable DB Replica on staging * fetch data uere with the score from MBD & remove non needed query * Fix some test cases about stable coin donations * fix: issue with adminJs authentication when user has hash as null * "Last Update" on project card is not correct * Fix some test cases about stable coin donations (#1665) * Fix some test cases about stable coin donations * Fix few test cases of projectResolver * Fix few test cases of projectResolver * Fix test cases of project resolver * Fix donationResolver test cases * Bump follow-redirects from 1.15.5 to 1.15.6 (#1414) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mohammadranjbarz <[email protected]> * Bump @solana/web3.js from 1.87.6 to 1.87.7 (#1492) Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 1.87.6 to 1.87.7. - [Release notes](https://github.com/solana-labs/solana-web3.js/releases) - [Commits](https://github.com/solana-labs/solana-web3.js/commits) --- updated-dependencies: - dependency-name: "@solana/web3.js" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mohammadranjbarz <[email protected]> * Bump express from 4.18.2 to 4.19.2 (#1430) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mohammadranjbarz <[email protected]> * Bump braces from 3.0.2 to 3.0.3 (#1629) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mohammadranjbarz <[email protected]> * Bump undici from 5.28.3 to 5.28.4 (#1454) Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.3...v5.28.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mohammadranjbarz <[email protected]> * fix types * Updated project verification form resolver test fixed previos 3 test with terms and condition update and added one last step test when user complete form and clicked "FINISH" button * fix extracting last comment * get donation to giveth with donation box analytics (#1661) * Add a method for finding relevant donations to the donationRepository.ts * Add a method for calculating donations metrics to the donationService.ts * Add a gql resolver for donations metrics to the donationResolver.ts * Add unit test for gql query resolver * Fix division by zero issue * times 100 average percentage to represent percent * add useDonationBox field to donation and draftDonation * fill useDonationBox field with correct data in migrations * Change donationMetrics endpoint based on change in data schema * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add false removed imports * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests based on changes * fix tests * send useDonationBox as last arg and make it optional * add relevant donation tx hash to donation creation flow * calculate related donations based on relevant donation tx hash * add unit tests * update unit test * fix bug * fix bug in donation repository and tests are pass * Clear All donations after donation metrics test cases * Add new function for deleting project from db and use it to don't affect other test cases * comment new test cases to ensure bug is related to that or not * Clear donations after tests * Comments new test cases in donationRepository.test.ts * uncomment tests and Clean up test effects on DB * Remove project addresses too * Add a new method to testUtils.ts for removing project from db by id * change donation dates to now * Remove clear donations sections * Change update count to a bigger number to pass test --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add test for fetching and refreshing qfroundscore for model * revert changes on package,json * revert changes on package,json * fix migration error * fix migration error * fix: turn minimumValidUsdValue to nullable when querying * remove updatedAt from projects tab * Remove old donation and add new ones (#1674) * remove verified from projects tab edit menu * remove verified from projectVerificationTab edit menu * fix total donations query * fix archived_round totals * fix latestUpdate column if not exists * fix join for totals * fix total donations with subquery * fix add some error handling and remove commented interface * fix: resolve conflict * fix: resolve conflict * fix USD value not showing * fix: convert timestap retrieved from RPC provider to milisconds * fix: donation test cases (milliseconds) * fix: donation test cases (milliseconds) * Endaoment integration (#1663) * Remove giving block projects that don't have any donation related to #1599 * Add needed fields to organization entity for endaoment projects related to Giveth/Roadmap#111 * Remove giving-blocks stuff and endaoment integration thing * Add categories to endaoment projects * Fix test cases * Fix some test cases about stable coin donations * Add endaoment categories * Fix remove giving-blocks projects migration * Add default image for endaoment projects * Fix linter * Fix add useDonationBox to draft_donation migration * Fix migration of adding useDonationBox to donation * Fix eslint error * Fix disabling recurring donations for endaoment projects * Change givingBlock organization to endaoment in pre-test script * Remove test case of accepted tokens of giving blocks * Relate all base, optimism and mainnet tokens to endaoment organization related to #1626 * Fix migration query syntax * fix: donation test cases (milliseconds) * fix: donation test cases (milliseconds) * Modify ormconfig for running migrations * Run ts files for migrations * Make isRecipient of project_addresses of endaoment project true * Fix type error of one of endaoment projects * add test case for filling prices * Modify add endaoment organization migration to pass the tests * fix: convert minimumUserAnalysisScore to Float on qfRound entity * fix: revert migration changes * add log for filling prices * feat: add github on project socialmedia enum * Merge master to staging (#1696) * Release relevant donations (#1687) * get donation to giveth with donation box analytics (#1661) * Add a method for finding relevant donations to the donationRepository.ts * Add a method for calculating donations metrics to the donationService.ts * Add a gql resolver for donations metrics to the donationResolver.ts * Add unit test for gql query resolver * Fix division by zero issue * times 100 average percentage to represent percent * add useDonationBox field to donation and draftDonation * fill useDonationBox field with correct data in migrations * Change donationMetrics endpoint based on change in data schema * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add false removed imports * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests based on changes * fix tests * send useDonationBox as last arg and make it optional * add relevant donation tx hash to donation creation flow * calculate related donations based on relevant donation tx hash * add unit tests * update unit test * fix bug * fix bug in donation repository and tests are pass * Clear All donations after donation metrics test cases * Add new function for deleting project from db and use it to don't affect other test cases * comment new test cases to ensure bug is related to that or not * Clear donations after tests * Comments new test cases in donationRepository.test.ts * uncomment tests and Clean up test effects on DB * Remove project addresses too * Add a new method to testUtils.ts for removing project from db by id * change donation dates to now * Remove clear donations sections * Change update count to a bigger number to pass test --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Remove old donation and add new ones (#1674) * Remove unused variable --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * release analytics dashboard dropdown menu related chagnes (#1686) * use networkId instead of optimism-only flag (#1653) * Use networkId instead of optimismOnly flag * Update graphql queries for tests * Change network id to float in gql schema to fix unit tests --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add organization filter to projectsTab.ts in admin panel related to #1599 (comment) * Fill description summary for endaoment projects related to #1599 (comment) * Fix eslint errors * Replace special characters of slugs of endaoment projects with - related to Giveth/giveth-dapps-v2#4280 (comment) * Fix eslint errors * return hardcoded as user MBD score * rename qfRound minimumUserAnalysisScore field * Resolve conflicts (#1703) * Release relevant donations (#1687) * get donation to giveth with donation box analytics (#1661) * Add a method for finding relevant donations to the donationRepository.ts * Add a method for calculating donations metrics to the donationService.ts * Add a gql resolver for donations metrics to the donationResolver.ts * Add unit test for gql query resolver * Fix division by zero issue * times 100 average percentage to represent percent * add useDonationBox field to donation and draftDonation * fill useDonationBox field with correct data in migrations * Change donationMetrics endpoint based on change in data schema * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * remove unused import Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add false removed imports * add default value for useDonationBox field Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix tests based on changes * fix tests * send useDonationBox as last arg and make it optional * add relevant donation tx hash to donation creation flow * calculate related donations based on relevant donation tx hash * add unit tests * update unit test * fix bug * fix bug in donation repository and tests are pass * Clear All donations after donation metrics test cases * Add new function for deleting project from db and use it to don't affect other test cases * comment new test cases to ensure bug is related to that or not * Clear donations after tests * Comments new test cases in donationRepository.test.ts * uncomment tests and Clean up test effects on DB * Remove project addresses too * Add a new method to testUtils.ts for removing project from db by id * change donation dates to now * Remove clear donations sections * Change update count to a bigger number to pass test --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Remove old donation and add new ones (#1674) * Remove unused variable --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * release analytics dashboard dropdown menu related chagnes (#1686) * use networkId instead of optimism-only flag (#1653) * Use networkId instead of optimismOnly flag * Update graphql queries for tests * Change network id to float in gql schema to fix unit tests --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Modify endaoment categories and relate them to projects related to #1664 (comment) * Add canUseOnFrontend to category so can show a category but don't allow users to select them when create/update projects related to #1685 * Fix project resolver test case * fix CPU spikes * add new test case for project update * fix test case * Fix add endaoment integration * Filter isActive and canUseOnFrontend categories in projectResolver * Filter isActive and canUseOnFrontend categories in projectResolver * Return canUseOnFrontend in main category list * Comment migrations related to endaoment (#1706) * 1.24.0 * Test ci/cd * Fix build problem --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Lovel George <[email protected]> Co-authored-by: Lovel George <[email protected]> Co-authored-by: Ramin <[email protected]> Co-authored-by: Moe Shehab <[email protected]> Co-authored-by: Mitch <[email protected]> Co-authored-by: ali ebrahimi <[email protected]> Co-authored-by: Meriem-BM <[email protected]> Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: kkatusic <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Reshzera <[email protected]>
Resolve this issue: #651
Summary by CodeRabbit