optimize updateProjectStatistics #1625
Conversation
WalkthroughThe recent changes pivot around the enhancement of project and donation statistics functionalities. A notable addition is the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ProjectService
participant DonationRepository
Client->>ProjectService: request qfRoundStats
ProjectService->>DonationRepository: call qfRoundStats with projectId, qfRoundId
DonationRepository-->>ProjectService: return uniqueDonorsCount, sumValueUsd
ProjectService-->>Client: return statistics
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/repositories/donationRepository.ts (2 hunks)
- src/services/projectService.ts (2 hunks)
Additional comments not posted (2)
src/services/projectService.ts (2)
4-4: Confirmed the import change fromcountUniqueDonorsForRoundandsumDonationValueUsdForQfRoundtoqfRoundStats. Ensure all usages are updated accordingly.
37-42: The integration ofqfRoundStatsinupdateProjectStatisticscorrectly consolidates the statistics fetching logic, improving performance and maintainability.
| export async function qfRoundStats(params: { | ||
| projectId: number; | ||
| qfRoundId: number; | ||
| }): Promise<{ uniqueDonorsCount: number; sumValueUsd: number }> { | ||
| const { projectId, qfRoundId } = params; | ||
| const result = await ProjectEstimatedMatchingView.createQueryBuilder( | ||
| 'projectEstimatedMatchingView', | ||
| ) | ||
| .select('projectEstimatedMatchingView.sumValueUsd') | ||
| .where('projectEstimatedMatchingView.projectId = :projectId', { | ||
| projectId, | ||
| }) | ||
| .andWhere('projectEstimatedMatchingView.qfRoundId = :qfRoundId', { | ||
| qfRoundId, | ||
| }) | ||
| .getOne(); | ||
| const { uniqueDonorsCount = 0, sumValueUsd = 0 } = result || {}; | ||
| return { | ||
| uniqueDonorsCount, | ||
| sumValueUsd, | ||
| }; | ||
| } |
There was a problem hiding this comment.
The implementation of qfRoundStats efficiently fetches both unique donor counts and sum donation values in a single query. This should enhance performance by reducing the number of database calls.
Would you like me to help create unit tests for this new function?
Summary by CodeRabbit
New Features
Refactor