-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/issue 743 #1756
Feat/issue 743 #1756
Conversation
Merge to update the branch with the staging branch
WalkthroughThe changes introduce enhanced validation in the donation functionality, ensuring that users cannot donate to their own projects. This update includes new test cases that verify both the prevention of self-donations and the successful creation of donations by users who do not own the project. The adjustments improve the robustness of the application by firmly establishing role-based restrictions in the donation process. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Merge to pull the updated changes in staging branch
Update Branch with Staging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @HrithikSampson
LGTM
#743
I have added 2 test cases in donationResolver.test.ts inside createDonationTestCases.
Output of npm run test:donationResolver
Summary by CodeRabbit
New Features
Tests