Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drupal 9 #28

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Drupal 9 #28

merged 4 commits into from
Oct 16, 2020

Conversation

AronNovak
Copy link
Member

#26

Status

added the version to be included in the tests

@AronNovak
Copy link
Member Author

@amitaibu At least the tests do pass under Drupal 9 too, likely the actual compatibility is also quite close.

@grasmash
Copy link

grasmash commented Sep 4, 2020

Any reason not to merge this?

@amitaibu
Copy link
Member

amitaibu commented Sep 6, 2020

@AronNovak ^^ ?

@AronNovak
Copy link
Member Author

@grasmash @amitaibu The only reason that I never tested it on a Drupal 9 site by myself, but we may simply trust the tests and see what happens.

@amitaibu
Copy link
Member

amitaibu commented Sep 7, 2020

@grasmash have you tried it on D9?

@amitaibu amitaibu changed the title WIP: Drupal 9 Drupal 9 Oct 16, 2020
@amitaibu amitaibu merged commit ddde8fd into Gizra:8.x-1.x Oct 16, 2020
@amitaibu
Copy link
Member

Thanks folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AronNovak @grasmash @amitaibu