-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lan manager fixes #1792
Lan manager fixes #1792
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1792 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 786 786
Lines 12309 12315 +6
=======================================
+ Hits 12087 12093 +6
Misses 222 222 ☔ View full report in Codecov by Sentry. |
@atrovato Nice! Should we wait for feedback or merge this? |
@Pierre-Gilles I would prefer to get feedbacks from spenceur, to be sure it fixes its problems. |
8d2d36d
to
c5c4ece
Compare
c5c4ece
to
b364634
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
b364634
to
8a1bf81
Compare
Job #2245: Bundle Size — 9.38MiB (0%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current Job #2245 |
Baseline Job #2243 |
|
---|---|---|
5.18MiB |
5.18MiB |
|
302.44KiB |
302.44KiB |
|
0% |
0% |
|
51 |
51 |
|
158 |
158 |
|
1425 |
1425 |
|
20 |
20 |
|
0.81% |
0.81% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
Current Job #2245 |
Baseline Job #2243 |
|
---|---|---|
6.87MiB |
6.87MiB |
|
2.08MiB |
2.08MiB |
|
318.94KiB |
318.94KiB |
|
93.55KiB |
93.55KiB |
|
16.14KiB |
16.14KiB |
|
13.58KiB |
13.58KiB |
View job #2245 report View atrovato:lan-manager-fixes branch activity
8a1bf81
to
5ecc909
Compare
5ecc909
to
b76db76
Compare
b76db76
to
25ca87f
Compare
Description of change
Bug traced here: https://community.gladysassistant.com/t/probleme-service-lan-manager/8167/3?u=alextrovato
Test image:
atrovato/gladys:lan-manager