Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lan manager fixes #1792

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented May 18, 2023

Description of change

Bug traced here: https://community.gladysassistant.com/t/probleme-service-lan-manager/8167/3?u=alextrovato

  • Filter for unique MAC.
  • Avoid error message once scan stops.

Test image: atrovato/gladys:lan-manager

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a10629) 98.19% compared to head (25ca87f) 98.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1792   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         786      786           
  Lines       12309    12315    +6     
=======================================
+ Hits        12087    12093    +6     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles
Copy link
Contributor

@atrovato Nice! Should we wait for feedback or merge this?

@atrovato
Copy link
Contributor Author

@Pierre-Gilles I would prefer to get feedbacks from spenceur, to be sure it fixes its problems.
But... I'm still waiting :)

@atrovato atrovato force-pushed the lan-manager-fixes branch from 8d2d36d to c5c4ece Compare May 19, 2023 04:33
@atrovato atrovato force-pushed the lan-manager-fixes branch from c5c4ece to b364634 Compare May 27, 2023 10:15
@stale
Copy link

stale bot commented Jul 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2023
@stale
Copy link

stale bot commented Sep 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 27, 2023
@stale stale bot removed the stale label Oct 3, 2023
@relativeci
Copy link

relativeci bot commented Oct 3, 2023

Job #2245: Bundle Size — 9.38MiB (0%).

25ca87f(current) vs 5a10629 master#2243(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2245
     Baseline
Job #2243
No change  Initial JS 5.18MiB 5.18MiB
No change  Initial CSS 302.44KiB 302.44KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 158 158
No change  Modules 1425 1425
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.81% 0.81%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #2245
     Baseline
Job #2243
Not changed  JS 6.87MiB 6.87MiB
Not changed  IMG 2.08MiB 2.08MiB
Not changed  CSS 318.94KiB 318.94KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2245 reportView atrovato:lan-manager-fixes branch activity

@Pierre-Gilles Pierre-Gilles merged commit 87d2858 into GladysAssistant:master Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants