-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airplay speakers #2143
Airplay speakers #2143
Conversation
#2833 Bundle Size — 10.3MiB (+0.44%).aca4795(current) vs 216f637 master#2828(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2833 |
Baseline #2828 |
|
---|---|---|
Initial JS | 5.58MiB (+0.51% ) |
5.55MiB |
Initial CSS | 304.84KiB (+0.05% ) |
304.68KiB |
Cache Invalidation | 57.67% |
0% |
Chunks | 51 |
51 |
Assets | 172 (+0.58% ) |
171 |
Modules | 1505 (+0.67% ) |
1495 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.84% |
0.84% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 4 changes
4 regressions
Current #2833 |
Baseline #2828 |
|
---|---|---|
JS | 7.37MiB (+0.38% ) |
7.34MiB |
IMG | 2.49MiB (+0.68% ) |
2.48MiB |
CSS | 321.63KiB (+0.05% ) |
321.47KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.7KiB (+0.47% ) |
17.62KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch bertrandda:feat/airplay-audio Project dashboard
Generated by RelativeCI Documentation Report issue
1ae5e64
to
0cd305a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
=======================================
Coverage 98.50% 98.51%
=======================================
Files 867 874 +7
Lines 14243 14331 +88
=======================================
+ Hits 14030 14118 +88
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
8043bdd
to
e3a6591
Compare
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add possibility to let Gladys talk on Airplay speakers