-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force hardcoded paths to CLI beautifiers #164
Comments
Use |
Ended up using code from |
CLI beautifiers no longer need hardcoded/fixed paths to their executable, since the PATH and other environment variables are being auto-detected
Be careful with that code it's a bit unstable.. not like, in that it doesn't work.. just that it's hard to guarantee it works cross platform. Interactive login shells sometimes do weird things, like print out headers, etc. We changed it a couple of times to try and get the correct cross platform behaviour, it's working well at the moment, but if you depend on it perhaps it should be a separate npm package so it can be updated independently. |
Okay, so you've motivated me to try making my first npm module.. with this code. https://github.com/ioquatix/login-environment @Glavin001 I've added you as a collaborator so feel free to make any changes. Then once it is good and makes sense, we can release a 1.0.0 release and that way any improvements to the code would be shared between both this project and |
There have been many problems with the
$PATH
and using https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/cli-beautify.coffee#L37-L42 to automatically fix the$PATH
. This is not working out.atom-beautify/lib/langs/cli-beautify.coffee
Lines 45 to 50 in e59d7c3
atom-beautify/lib/langs/cli-beautify.coffee
Lines 45 to 50 in e59d7c3
$PATH
(for auto-detecting paths of CLI beautifiers)The text was updated successfully, but these errors were encountered: