Code

🔙 Improved NACKs#135

Code

Merged

danstiner merged 59 commits intomasterGlimesh/janus-ftl-plugin:masterfrom fix_extended_sequence_counterGlimesh/janus-ftl-plugin:fix_extended_sequence_counterCopy head branch name to clipboardJan 18, 2022

+1,068-426

Commits

Commits on Dec 8, 2021

• Allow skips of up to MAX_DROPOUT inclusive

  danstiner

  committed
  004f575

  Copy full SHA for 004f575

• Make constants public for testing

  danstiner

  committed
  970edd5

  Copy full SHA for 970edd5

• Start maxSeq at seq like RFC example does

  danstiner

  committed
  4d052fb

  Copy full SHA for 4d052fb

• Update tests to be more clear

  danstiner

  committed
  df424e6

  Copy full SHA for df424e6

• Formatting

  danstiner

  committed
  b434820

  Copy full SHA for b434820

• Introduce ExtendResult struct

  danstiner

  committed
  b9a836b

  Copy full SHA for b9a836b

• Pass SsrcData instead of lock

  Show description for e81d1c6
  danstiner

  committed
  e81d1c6

  Copy full SHA for e81d1c6

• Put all nack behavior behind config setting

  danstiner

  committed
  b5c380c

  Copy full SHA for b5c380c

• Extract better named captureVideoKeyframe method

  danstiner

  committed
  35637f7

  Copy full SHA for 35637f7

• Extract sendQueuedNacks method

  danstiner

  committed
  96b1772

  Copy full SHA for 96b1772

Commits on Dec 9, 2021

• Handle a few percent of packet loss

  danstiner

  committed
  6d9de37

  Copy full SHA for 6d9de37

• Improve log message

  danstiner

  committed
  3282004

  Copy full SHA for 3282004

• Improved logging

  danstiner

  committed
  41f3c8e

  Copy full SHA for 41f3c8e

• Fix issue where sequence tracker locked up after prolonged run time

  danstiner

  committed
  7425cc2

  Copy full SHA for 7425cc2

• Downgrade nack logging to trace level

  danstiner

  committed
  b5e1812

  Copy full SHA for b5e1812

• Allow for more jitter

  danstiner

  committed
  a3b89e2

  Copy full SHA for a3b89e2

• Log if we exceed nack capability

  danstiner

  committed
  8691b7b

  Copy full SHA for 8691b7b

Commits on Dec 10, 2021

• Merge remote-tracking branch 'origin/master' into fix_extended_sequence_counter

  danstiner

  committed
  30cf734

  Copy full SHA for 30cf734

Commits on Dec 13, 2021

• Format

  danstiner

  committed
  f8069f1

  Copy full SHA for f8069f1

• Basic sequence tracker tests

  danstiner

  committed
  d811607

  Copy full SHA for d811607

• Log sequence counter resets

  danstiner

  committed
  e670fd1

  Copy full SHA for e670fd1

• Test NACKs do not cause resets

  danstiner

  committed
  e791a72

  Copy full SHA for e791a72

• Cleanup

  danstiner

  committed
  3fc6938

  Copy full SHA for 3fc6938

• Move counter into sequence tracker

  danstiner

  committed
  aba1744

  Copy full SHA for aba1744

• Cleanup received buffer

  danstiner

  committed
  ff03673

  Copy full SHA for ff03673

• Keep mapping of nacked packets instead of re-extending

  danstiner

  committed
  af92711

  Copy full SHA for af92711

• Fix packet metrics

  danstiner

  committed
  a6da8e7

  Copy full SHA for a6da8e7

• Failing test due holding on to nack'd packets for too long

  danstiner

  committed
  dd053f8

  Copy full SHA for dd053f8

• Verbose logging in tests

  danstiner

  committed
  7d480ea

  Copy full SHA for 7d480ea

Commits on Dec 14, 2021

• Only reset tracking on a resync, not initial sync

  danstiner

  committed
  b600728

  Copy full SHA for b600728

• Log packet stats

  danstiner

  committed
  8a40fb0

  Copy full SHA for 8a40fb0

• Set default log level to debug

  danstiner

  committed
  33153c3

  Copy full SHA for 33153c3

• Trace entire nack queue

  danstiner

  committed
  6de4c34

  Copy full SHA for 6de4c34

• Tweak buffer sizes based on testing and 6mbps stream

  danstiner

  committed
  2cbf196

  Copy full SHA for 2cbf196

• Fix reorder buffer to cleanup by size first, then timeout

  danstiner

  committed
  099f3fb

  Copy full SHA for 099f3fb

• Increase reorder buffer timeout

  danstiner

  committed
  fb7292d

  Copy full SHA for fb7292d

• Reduce keyframe logging to trace

  danstiner

  committed
  a67cfa0

  Copy full SHA for a67cfa0

• Reduce buffer timeout to 20ms

  danstiner

  committed
  76f3c25

  Copy full SHA for 76f3c25

Commits on Dec 15, 2021

• Test for many outstanding NACKs

  danstiner

  committed
  1cac649

  Copy full SHA for 1cac649

• Timeout outstanding NACKs

  danstiner

  committed
  96914f4

  Copy full SHA for 96914f4

• Update build job to match dockerfile versions

  danstiner

  committed
  376ff54

  Copy full SHA for 376ff54

Commits on Dec 16, 2021

• Reset .github/workflows/build.yml

  danstiner

  committed
  1a1bfe9

  Copy full SHA for 1a1bfe9

• Merge remote-tracking branch 'origin/master' into fix_extended_sequence_counter

  danstiner

  committed
  65a8b16

  Copy full SHA for 65a8b16

• Undo some auto formatting changes

  danstiner

  committed
  2eb0031

  Copy full SHA for 2eb0031

• Cleanup tests a bit

  danstiner

  committed
  3fb8122

  Copy full SHA for 3fb8122

• Cleanup formatting

  danstiner

  committed
  15f4e4c

  Copy full SHA for 15f4e4c

• Fix formatting take 2

  danstiner

  committed
  902ce3f

  Copy full SHA for 902ce3f

• Merge remote-tracking branch 'origin/master' into fix_extended_sequence_counter

  danstiner

  committed
  76d899f

  Copy full SHA for 76d899f

• Improve log message

  danstiner

  committed
  29e0bc4

  Copy full SHA for 29e0bc4

Commits on Dec 17, 2021

• Re-write sequence tracker

  danstiner

  committed
  2b2aa86

  Copy full SHA for 2b2aa86

• Track nack count in SequenceTracker

  danstiner

  committed
  07c78b3

  Copy full SHA for 07c78b3

• Formatting

  danstiner

  committed
  1db75a2

  Copy full SHA for 1db75a2

• Improve handling of keyframes

  danstiner

  committed
  78488f2

  Copy full SHA for 78488f2

• Formatting

  danstiner

  committed
  7217d8d

  Copy full SHA for 7217d8d

• Use .end() to correctly access last packet

  danstiner

  committed
  44509ee

  Copy full SHA for 44509ee

• Fix IsComplete check

  danstiner

  committed
  0d23274

  Copy full SHA for 0d23274

Commits on Dec 22, 2021

• Improved names and documentation

  danstiner

  committed
  fc6322d

  Copy full SHA for fc6322d

Commits on Jan 18, 2022

• Inline ExtendedSequenceCounter::resync

  danstiner

  committed
  75b6566

  Copy full SHA for 75b6566

• Formatting

  danstiner

  committed
  0f6dfbb

  Copy full SHA for 0f6dfbb