Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save H264 video to disk #10

Open
clone1018 opened this issue Mar 2, 2023 · 2 comments
Open

Save H264 video to disk #10

clone1018 opened this issue Mar 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@clone1018
Copy link
Member

In order to support our future goals of providing users Video on Demand of previous streams, and Clips of particular sections of a live stream, we need to know how to save H264 to disk in a playable way.

My theory is that we could easily do this in a way similar to how Peer Snap works (and based on the architecture we come up with in #7). Since we'll be able to consume the RTP packets, and save them directly to disk.

Some Pion examples:

@nassah221
Copy link
Collaborator

I'm looking to pick this up. In the pion examples, the stream is written in ivf container for VP8. Do we want to use a container for our h264 streams (mpegtsmux?) or just write them as .h264 on disk?

Also, is it better to prioritise #7? IMO the thumbnailer code needs refactoring as we would need to generalize it to cover both cases of writing to disk and sending thumbnails.

@clone1018
Copy link
Member Author

We'll have to implement a container for the eventual #12. I'm in agreement that #7 might be a good first start though to improve handling of these "outputs" that don't actually send their data anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants