Implement save to disk for h264 video stream #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10
For now, the save to disk is enabled at the control level by
save_video
flag.I didn't feel that
outputs
was the right place for configuring the file-writer due to absence of aListen
orServe
method on the writer. Since save-to-disk will be handled on per-stream basis in the future anyways, I thought it better to handle it at the control level.I also moved
keyframer
to it's own package and broke up the ingestor, thumbnailer and file-writer code into separate files