Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement save to disk for h264 video stream #27

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

nassah221
Copy link
Collaborator

Addresses #10

For now, the save to disk is enabled at the control level by save_video flag.

I didn't feel that outputs was the right place for configuring the file-writer due to absence of a Listen or Serve method on the writer. Since save-to-disk will be handled on per-stream basis in the future anyways, I thought it better to handle it at the control level.

I also moved keyframer to it's own package and broke up the ingestor, thumbnailer and file-writer code into separate files

@nassah221 nassah221 requested a review from clone1018 April 10, 2023 21:06
@nassah221 nassah221 marked this pull request as ready for review April 10, 2023 21:06
Copy link
Member

@clone1018 clone1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Uses the channel work you did with Thumbnailer well, and is setup for future codecs.

@clone1018
Copy link
Member

You should be able to merge this branch on your own, feel free when you are ready!

@nassah221 nassah221 merged commit 1cab06f into main Apr 17, 2023
@nassah221 nassah221 deleted the feature/save-h264-to-disk branch April 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants