Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alolan Pokemon Update #19

Merged
merged 46 commits into from
Jul 11, 2022
Merged

Alolan Pokemon Update #19

merged 46 commits into from
Jul 11, 2022

Conversation

timoetzold
Copy link

I fixed the GameMasterParser and updated the resource files, so Alolan Pokemon will work.

@jimmywan
Copy link

I haven't worked on this codebase, but the diffs (ignore whitespace) look fairly reasonable to me.
Happy to beta test a build if we get one put together.

@lramati
Copy link
Collaborator

lramati commented Mar 26, 2022

I'm going to merge this, but I think we need a solution for pumpkaboo and gourgeist. I think each size has different stats, and I'm not sure if we're capable of supporting that right now?

@timoetzold
Copy link
Author

I did check those as it annoyed me, that the app could not detect other sizes than average. But with this change it is possible!

@lramati
Copy link
Collaborator

lramati commented Mar 26, 2022

Come to think of it, I don't know if I released a new version when those pokemon were added, maybe its just an old change from when they were actually officially added to the game?

@timoetzold
Copy link
Author

I guess so. I don't remember either if a new version was released after those were added.

@lramati
Copy link
Collaborator

lramati commented Mar 26, 2022

Could you just add another commit to bump the version? in app\build.gradle, bump versionCode to 74 and versionName to 5.5.7

@timoetzold
Copy link
Author

Unfortunately I am on vacation with family, but I can do this tomorrow evening.

@timoetzold
Copy link
Author

Any update on this?

@timoetzold
Copy link
Author

This PR now also resolves #7 #8 #9 #12

@timoetzold timoetzold deleted the branch GoIV-Devs:master May 2, 2022 17:49
@timoetzold timoetzold closed this May 2, 2022
@timoetzold timoetzold deleted the master branch May 2, 2022 17:50
@timoetzold timoetzold restored the master branch May 2, 2022 17:50
@timoetzold timoetzold reopened this May 2, 2022
@timoetzold
Copy link
Author

Renaming my default branch to main did close this PR, so I reopened it...

@timoetzold
Copy link
Author

The PR now also resolves #11

(cherry picked from commit 425804b)
@timoetzold
Copy link
Author

I did some cleanup in the codebase and included commits from @RebelliousUno since my PR replaces #13.
Also I increased the minsdk to 23 and removed the workarounds so this PR also resolves #18.

@timoetzold
Copy link
Author

I just noticed that at least the online versions need some more work... They currently don't compile as the firebase API changed.

@timoetzold
Copy link
Author

Implementation is now updated to use FirebaseCrashlytics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants