-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alolan Pokemon Update #19
Conversation
I haven't worked on this codebase, but the diffs (ignore whitespace) look fairly reasonable to me. |
I'm going to merge this, but I think we need a solution for pumpkaboo and gourgeist. I think each size has different stats, and I'm not sure if we're capable of supporting that right now? |
I did check those as it annoyed me, that the app could not detect other sizes than average. But with this change it is possible! |
Come to think of it, I don't know if I released a new version when those pokemon were added, maybe its just an old change from when they were actually officially added to the game? |
I guess so. I don't remember either if a new version was released after those were added. |
Could you just add another commit to bump the version? in app\build.gradle, bump versionCode to 74 and versionName to 5.5.7 |
Unfortunately I am on vacation with family, but I can do this tomorrow evening. |
Any update on this? |
Renaming my default branch to main did close this PR, so I reopened it... |
The PR now also resolves #11 |
(cherry picked from commit 425804b)
using the plugin from matching IDEA might be better
I did some cleanup in the codebase and included commits from @RebelliousUno since my PR replaces #13. |
I just noticed that at least the online versions need some more work... They currently don't compile as the firebase API changed. |
Implementation is now updated to use FirebaseCrashlytics |
I fixed the GameMasterParser and updated the resource files, so Alolan Pokemon will work.