Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gen 9 Pokemon #42

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Update Gen 9 Pokemon #42

merged 2 commits into from
Sep 12, 2023

Conversation

AndrewMcQuerry
Copy link

Change Log

  • Update Gen 9 Pokemon from PokeMiners
  • Update to gradle:7.4.2 (auto-updated by Android Studio)
  • Update gradle distributionUrl (auto-updated by Android Studio)

@timoetzold
Copy link

timoetzold commented Sep 11, 2023

The file "app/src/main/res/values-zh-rCN/pokemons.xml" did not only change on the lines for the new pokemon. That needs to be checked first before accepting this PR.

@AndrewMcQuerry
Copy link
Author

Good catch. Not sure what could have caused that. Is it possible I have an incorrect UTF or language setting? Also, where do those values come from? Do they just get copied from names.csv?

@AndrewMcQuerry
Copy link
Author

Found my mistake. I had accidentally used the zh-rTW list when updating zh-rCN.

The latest commit fixes that and now the changes are only to the expected new pokemon.

@timoetzold
Copy link

How did you do the update? Normally you would run the gradle task ":devMethods:updateDatabase".

@timoetzold timoetzold merged commit 26d5aae into GoIV-Devs:main Sep 12, 2023
@AndrewMcQuerry
Copy link
Author

Within Android Studio, I ran ApplicationDatabaseUpdater.java directly (from within the devMethods directory. This created files in that directory that I then copied into their respective files.

I honestly didn't know exactly how it was done previously. If there are other things the gradle task does, then maybe this PR should just be closed so that it can be done the correct way.

@timoetzold
Copy link

already merged. Well the task does the same, but you don't have to do anything manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants