Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing header check location for webms #587

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

mitt3n
Copy link
Contributor

@mitt3n mitt3n commented Aug 29, 2024

Summary

Webm header check bytes location is wrong. This is untested, however:

>>> file = open("/home/user/file.webm", "rb")
>>> bytes = file.read(36)
>>> print(bytes[22:29])
b'\x82\x84webmB'

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Gobot1234
Copy link
Owner

Thanks

@Gobot1234 Gobot1234 merged commit 0a9f6d8 into Gobot1234:main Aug 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants