Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties forwarding to only forward customized properties. #647

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix properties forwarding to only forward customized properties. #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions VERSIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 4.3.3
- Fix Viewport2Din3D property forwarding

# 4.3.2
- Move fade logic into effect
- Added collision fade support
Expand Down
4 changes: 2 additions & 2 deletions addons/godot-xr-tools/objects/viewport_2d_in_3d.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ func _update_scene_property_list():
var all_properties := node_script.get_script_property_list()

# Join this with the custom property list of the object created by the script
if scene_node.has_method("get_property_list"):
all_properties.append_array(scene_node.get_property_list())
if scene_node.has_method("_get_property_list"):
all_properties.append_array(scene_node.call("_get_property_list"))

for property in all_properties:
# Filter out only the properties that are supposed to be stored, or are used for grouping
Expand Down
Loading