Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ros integration #7

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

DUDEbehindDUDE
Copy link
Member

@DUDEbehindDUDE DUDEbehindDUDE commented Mar 4, 2025

This pull request adds functionality to be able to properly communicate with ROS, and once this PR is merged this Should (TM) be the final thing needed for the HMI to be at it's minimum viable product. Included in this PR are the main features that are needed to be able to get ROS communication up and working. The current state of this is PR is that it is mostly working however the communication is currently only 1 way (it is only listening for messages at the moment).

Here is a checklist for this PR:

  • Implement websocket communication
  • Connect to and receive messages from web sockets asynchronously
  • Update and subscribe to topics in a data driven way
  • Attempt reconnections to web socket if it fails or isn't able to connect
  • Update state based on web socket context
  • Filter messages by topic
  • Get web socket connection IP from environment variable
  • Be able to send messages (for starting/stopping the bot)
  • Figure out a way to be able to determine statuses (this may become a future PR... we'll see)
  • Create ROS publisher to be able to update the HMI with current topic data (ros/src/node_info)
  • Rewrite tests based on new code functionality
  • Update README to reflect new processes

Hudson111-s
Hudson111-s previously approved these changes Mar 4, 2025
Copy link

@Hudson111-s Hudson111-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should definitely look into "Be able to send messages (for starting/stopping the bot)" asap.

@DUDEbehindDUDE
Copy link
Member Author

It's a draft PR 😭 this is just to track progress

@DUDEbehindDUDE
Copy link
Member Author

You can still do code reviews mid pr though if you see things that should be changed but this isn't going to get merged for a bit

@Hudson111-s
Copy link

It's a draft PR 😭 this is just to track progress

Yeah I know... was just saying that it looked good for now and we should probably focus on the "start button" for the robot 🙃

@DUDEbehindDUDE DUDEbehindDUDE self-assigned this Mar 7, 2025
@DUDEbehindDUDE DUDEbehindDUDE added the enhancement New feature or request label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants