-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ros integration #7
base: main
Are you sure you want to change the base?
Conversation
I don't feel like writing a mock component for state right now so no tests yippee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should definitely look into "Be able to send messages (for starting/stopping the bot)" asap.
It's a draft PR 😭 this is just to track progress |
You can still do code reviews mid pr though if you see things that should be changed but this isn't going to get merged for a bit |
Yeah I know... was just saying that it looked good for now and we should probably focus on the "start button" for the robot 🙃 |
Merge main into feature/ros-integration
This pull request adds functionality to be able to properly communicate with ROS, and once this PR is merged this Should (TM) be the final thing needed for the HMI to be at it's minimum viable product. Included in this PR are the main features that are needed to be able to get ROS communication up and working. The current state of this is PR is that it is mostly working however the communication is currently only 1 way (it is only listening for messages at the moment).
Here is a checklist for this PR:
ros/src/node_info
)