Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for multiple accounts with same implants in same location #501

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

coanghel
Copy link
Contributor

Hashes location + item + owner when generating item id for plugged implants to account for possibility of same implants in same location across multiple accounts/characters.

fixes #499

@GoldenGnu
Copy link
Owner

LGTM 👍
Bug fixes need to be committed to main, I don’t know how hard that would be to change, I’m not very good at git.

@coanghel
Copy link
Contributor Author

The only reason I didn't is because the feature (implant asset tracking) isn't in the main branch yet... I think?

@GoldenGnu
Copy link
Owner

Yes, sorry about that.

My only excuse is that It confused me there was an issue too, that normally only happens with stuff I have already released.

Anyway, thanks for the feature fix and it’s definitely nice you made an issue for it too.

I will merge it as soon as I have some spare time

@coanghel
Copy link
Contributor Author

Added a commit to dynamically inject the ESI client ID from Maven properties:

image

@GoldenGnu
Copy link
Owner

I finally got around to merge this. I'm going to revert your changes to EsiCallbackURL.java, because I need to be able to check the value are set before I deploy. Sorry about that.

Thank you for all your work! 👍

@GoldenGnu GoldenGnu merged commit 41647cf into GoldenGnu:develop Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants