-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PDF metadata extraction #17
base: main
Are you sure you want to change the base?
Conversation
Oh, interesting! I may not have time to look at this in detail today. One thing to consider is that the various PLAYA objects don't produce anything particularky useful with I would just use Pydantic but I don't want any dependencies :) |
I'd be happy to help. Also I dont think pydantic is required. |
Indeed - particularly since no validation is implied. The idea would be that instead of calling |
This would be awesome 😎. Defintely save me a lot of work. When do you see this on your roadmap? And should I continue implementation on my end, or hold off for now? Also, consider using I'd drop python 3.8 since it's deprecated and has issues with some typing. |
Probably one of the next things that I'll do, for the next release (next week).
You could - though I think the schemas for the metadata might end up being a bit different that what you've got now.
Oh, this is handy ... much better than just adding
Even though it's end of life I think it's important to keep supporting it, as it's what came with Ubuntu 20.04 and not everybody has upgraded that yet... |
@dhdaines any updates on your end? |
Thanks for the reminder! I'll have some time to look at it today. |
thanks, please update me when you release the new API. If you can document it - would be awesome. |
Working on it here: dhdaines/playa#68 And a new version of this PR to go with it (not complete): #25 |
This PR integrates PDF metadata extraction using playa, relates to: dhdaines/playa#63