Merge into the fork #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix durations in D3 graph (fixes #2620) Fixes the duration calculation. Both date objects `startTime` and `finishTime` are in milliseconds, so the additional multiplication with 1000 was wrong. Also, the duration is now calculated with: duration = last_updated - time_running as it is done in datadog_metric.py:83 I decided to not display the time if the duration is longer than a day, because then it gets messy with the Date objects (would require a conversion to day of year, not day of month). * Remove code duplication.
- changed `track_url_in_stderr` to `stream_for_searching_tracking_url` according to the latest changes in external_program.py - added tests for spark url tracking in cluster and client modes
…uld require only complete months. (#2666)
This fixes a DeprecationWarning which would have broken in Python 3.8.
…dules entry (#2692) The configration doc contains entry on `[core]max_reschedules`, which is not only deprecated (in favor of `[worker]max_reschedules`) but also wrong: the correct (but deprecated) config key is `[core]worker-max-reschedules`. Better get rid of this all together and just keep `[worker]max_reschedules`
…task add beam_dataflow_task to luigi/contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Have you tested this? If so, how?