Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Updates to webstore docs, removing spurious references #749

Merged
merged 7 commits into from
Jun 18, 2021
Merged

Conversation

awfuchs
Copy link
Contributor

@awfuchs awfuchs commented May 7, 2021

Removed references to Chrome Web Store Payments and many references to apps.

@netlify
Copy link

netlify bot commented May 7, 2021

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: fb815db

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/60cce6e6213eff0007fc5f1f

😎 Browse the preview: https://deploy-preview-749--developer-chrome-com.netlify.app

@chrome-devrel-review-bot
Copy link
Collaborator

chrome-devrel-review-bot commented May 7, 2021

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/webstore/about_webstore/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/webstore/best_practices/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/webstore/branding/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/webstore/faq/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 36, 44, 51, 68, 219, 225, 230, 255, 256, 324
  • Please change your usage of the following words:
    • Avoid please. Affected lines: 13, 149, 158, 230, 313, 317, 333, 334

site/en/docs/webstore/identify_user/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/webstore/images/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 24, 27, 69, 84, 168, 207, 212, 219, 261, 278, 283, 291, 295, 297

site/en/docs/webstore/rating/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/webstore/troubleshooting/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 706

@pullapprove pullapprove bot requested a review from dotproto May 7, 2021 21:23
@awfuchs awfuchs marked this pull request as ready for review May 17, 2021 22:37
Copy link
Contributor

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're mostly there, but there are a few bits that don't quite seem to operating as intended.

I noticed that within this PR we have pages that we're keeping that link to pages we're deleting. It may be worth searching through the corpus for other links to ensure that we're not trying to link to unreachable content.

@awfuchs
Copy link
Contributor Author

awfuchs commented Jun 17, 2021

Opened #898 to look for other links broken by this or other purges.

@awfuchs awfuchs requested a review from dotproto June 17, 2021 16:07
Copy link
Contributor

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a couple edits, but I think we're good after that.

@awfuchs awfuchs merged commit 3dc8ad1 into main Jun 18, 2021
@awfuchs awfuchs deleted the no-apps-no-pmts branch June 18, 2021 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants