You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I'm attempting to run the psi cron job against all of our public pages on prod. We have a high number of them (~40), so sending all of the fetch requests in parallel overwhelms the pagespeed insights api and tanks out with the error PSI collection failure for Production LHCI Cron Job - Home: PSI Failed (500): Lighthouse returned error: Something went wrong. (I've been able to replicate this outside of this package). I'd like to be able to limit the number of parallel requests sent to the pagespeed insights api.
Also, a few of our pages error out when requesting the pwa category. I'd like to be able to opt out of categories from the config.
The above could be 2 separate issues, but I've grouped them together as these could both be optional psi configurations. While we're here, we could make other details configurable (see #420)
Describe the solution you'd like
I think the config could look something like:
psiCollectCron: {
...currentPsiCollectCronConfig,sites: [{
...currentSiteConfig,maxNumberOfParallelUrls: number,// default: Infinity (run all urls in parallel - current behavior)excludeCategories: ['performance'|'accessibility'|'best-practices'|'pwa'|'seo'],// default: [] (run all categories - current behavior)strategy: 'desktop'|'mobile'// default: 'mobile' (current behavior)},
...etc]}
It wouldn't be difficult to set up an async counter to ensure a max number of requests are being processed in parallel. Even easier to just pass config values to each run.
Describe alternatives you've considered
Without being able to configure the number of parallel calls (hardcoded here) or being able to configure the categories (hardcoded here), I don't see alternatives aside from setting up our own implementation of this. Not that this would be terribly difficult, but I'd rather make these few pieces configurable since it would be almost identical to this package.
Additional context
Happy to open a PR, just wanted to get a pulse on if there is any opposition and why.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
PSI collection failure for Production LHCI Cron Job - Home: PSI Failed (500): Lighthouse returned error: Something went wrong.
(I've been able to replicate this outside of this package). I'd like to be able to limit the number of parallel requests sent to the pagespeed insights api.pwa
category. I'd like to be able to opt out of categories from the config.The above could be 2 separate issues, but I've grouped them together as these could both be optional psi configurations. While we're here, we could make other details configurable (see #420)
Describe the solution you'd like
I think the config could look something like:
It wouldn't be difficult to set up an async counter to ensure a max number of requests are being processed in parallel. Even easier to just pass config values to each run.
Describe alternatives you've considered
Without being able to configure the number of parallel calls (hardcoded here) or being able to configure the categories (hardcoded here), I don't see alternatives aside from setting up our own implementation of this. Not that this would be terribly difficult, but I'd rather make these few pieces configurable since it would be almost identical to this package.
Additional context
Happy to open a PR, just wanted to get a pulse on if there is any opposition and why.
The text was updated successfully, but these errors were encountered: