Allow for further configuration of psiCollectCron #696
Conversation
| projectSlug, | ||
| numberOfRuns = 5, | ||
| maxNumberOfParallelUrls = Infinity, | ||
| categories = ['performance', 'accessibility', 'best-practices', 'pwa', 'seo'], |
There was a problem hiding this comment.
maybe don't default it here, so it can fallback to the default in psi-client?
packages/utils/src/psi-runner.js
Outdated
| @@ -19,20 +19,22 @@ class PsiRunner { | |||
|
|
|||
| /** | |||
| * @param {string} url | |||
| * @param {{psiApiKey?: string, psiApiEndpoint?: string, psiStrategy?: 'mobile'|'desktop'}} [options] | |||
| * @param {{psiApiKey?: string, psiApiEndpoint?: string, psiStrategy?: 'mobile'|'desktop', categories?: Array<'performance' | 'accessibility' | 'best-practices' | 'pwa' | 'seo'>}} [options] | |||
There was a problem hiding this comment.
these options are all redundantly prefixed with psi because the CLI collect command can also use them, I think it might be worth doing at this level for psiCategories as well :) (but in psi-client, definitely leave without prefix)
WDYT?
There was a problem hiding this comment.
Yeah, sounds very reasonable to stay consistent.
Co-authored-by: Patrick Hulce <[email protected]> Co-authored-by: Patrick Hulce <[email protected]>
jonathantredway
force-pushed
the
additional-psi-configurations
branch
from
8b30b64 to
8a1acbd
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@patrickhulce Addressed the feedback ✅, but used the github client to auto-commit your suggestions so it looks like you'll just need to appease googlebot with a consent comment. |
|
@googlebot I consent |
closes #695