Update debug messages when checking hash uniqueness

[ianjmacintosh]

Based on the thread in the attached ticket, I've clarified the debug messages when LHCI checks commit hash uniqueness.

Close #612

[patrickhulce]

thanks @ianjmacintosh! I expect there will be some test expectations to update :)

[ianjmacintosh]

thanks @ianjmacintosh! I expect there will be some test expectations to update :)

Hehe, yeah, right on. When I searched the project for the string in question (to find it in the first place), I just found it in that one location, but we'll see! 🎲🎲

[ianjmacintosh]

Yep, I'm seeing some failing tests, time to chase them down.

[ianjmacintosh]

Running the tests locally shows some errors that I suspect are just specific to my own environment and would require some more digging to straighten out. Instead of tackling those in order to get passing tests locally before pushing, I've updated the tests that looked relevant and am giving it another shot.

If I see failures on the status checks again, I'll do a deeper dive to get the tests passing locally before trying again.

[patrickhulce]

packages/cli/test/autorun-start-server.test.js should be the only one left to worry about :)

[ianjmacintosh]

Yeah, I'm pretty sure that's the case and I've already got that commit ready, but I feel like I should be able to run tests locally before passing them off to CI. Hang tight 🦥

[patrickhulce]

I feel like I should be able to run tests locally before passing them off to CI

I think a few might be failing because of a fork. There are a few tests we need to configure to be skipped that rely on the git history of the upstream repo.

[ianjmacintosh]

Yeah, that was definitely part of it, so I changed my remotes. I was also not running yarn build:watch or yarn start:server as outlined in the "development flow" part of CONTRIBUTING.md. Now when I run the tests I see failures in storybook.test.jsx, simple-comparison.test.js, and different-category-comparison.test.js, but there's a debugging message buried in the miles of console output that makes it sound like I didn't prep something related to storybook properly.

Since that's almost definitely unrelated, I pushed my changes so CI can test while I figure out my local environment issues.

[ianjmacintosh]

Yep, all good, all checks passed 🥳

[patrickhulce]

thanks very much @ianjmacintosh! 🎉