Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify node.js version in Github Actions example #679

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Specify node.js version in Github Actions example #679

merged 1 commit into from
Aug 23, 2021

Conversation

j0nas
Copy link
Contributor

@j0nas j0nas commented Aug 23, 2021

Specify node.js version for actions/setup-node@v1 step in example Github Actions code. Without this, the snippet currently fails as it defaults to an earlier version of node.js which raises a SyntaxError for the current version of the module.

Specify node.js version for `actions/setup-node@v1` step in example Github Actions code. Without this, the snippet currently fails as it defaults to an earlier version of node.js which raises a SyntaxError for the current version of the module.
@google-cla
Copy link

google-cla bot commented Aug 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@j0nas
Copy link
Contributor Author

j0nas commented Aug 23, 2021

@googlebot I signed it!

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @j0nas!

@patrickhulce patrickhulce merged commit c43ec3b into GoogleChrome:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants