Rename optimized animated image audit

GoogleChrome · Apr 12, 2018 · 1ac3263 · 1ac3263
1 parent a08008f
commit 1ac3263
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 18 deletions.
diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -157,7 +157,7 @@ <h2>Do better web tester page</h2>
 <!-- PASS(image-aspect-ratio) -->
 <img src="lighthouse-480x318.jpg" width="480" height="318">
 
-<!-- FAIL(uses-optimized-animated-images): animated gif found -->
+<!-- FAIL(efficient-animated-content): animated gif found -->
 <img src="lighthouse-rotating.gif" width="811" height="462">
 
 <!-- Some websites overwrite the original Error object. The captureJSCallUsage function

diff --git a/lighthouse-cli/test/smokehouse/dbw-config.js b/lighthouse-cli/test/smokehouse/dbw-config.js
@@ -19,7 +19,7 @@ module.exports = {
       'link-blocking-first-paint',
       'script-blocking-first-paint',
       'errors-in-console',
-      'uses-optimized-animated-images',
+      'efficient-animated-content',
     ],
   },
 };
diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
@@ -185,7 +185,7 @@ module.exports = [
           },
         },
       },
-      'uses-optimized-animated-images': {
+      'efficient-animated-content': {
         score: 0,
         details: {
           items: [

diff --git a/...iciency/uses-optimized-animated-images.js → ...-efficiency/efficient-animated-content.js b/...iciency/uses-optimized-animated-images.js → ...-efficiency/efficient-animated-content.js
@@ -14,13 +14,13 @@ const ByteEfficiencyAudit = require('./byte-efficiency-audit');
 // the threshold for the size of GIFs wich we flag as unoptimized
 const GIF_BYTE_THRESHOLD = 100 * 1024;
 
-class UsesOptimizedAnimatedImages extends ByteEfficiencyAudit {
+class EfficientAnimatedContent extends ByteEfficiencyAudit {
   /**
    * @return {!AuditMeta}
    */
   static get meta() {
     return {
-      name: 'uses-optimized-animated-images',
+      name: 'efficient-animated-content',
       scoreDisplayMode: ByteEfficiencyAudit.SCORING_MODES.NUMERIC,
       description: 'Use a video formats for animated content',
       helpText: 'Large GIFs are inefficient for delivering animated content. Consider using ' +
@@ -44,7 +44,7 @@ class UsesOptimizedAnimatedImages extends ByteEfficiencyAudit {
    * @return {!AuditResult}
    */
   static async audit_(artifacts) {
-    const devtoolsLogs = artifacts.devtoolsLogs[UsesOptimizedAnimatedImages.DEFAULT_PASS];
+    const devtoolsLogs = artifacts.devtoolsLogs[EfficientAnimatedContent.DEFAULT_PASS];
 
     const networkRecords = await artifacts.requestNetworkRecords(devtoolsLogs);
     const unoptimizedContent = networkRecords.filter(
@@ -57,7 +57,7 @@ class UsesOptimizedAnimatedImages extends ByteEfficiencyAudit {
       return {
         url: record.url,
         totalBytes: record.resourceSize,
-        wastedBytes: record.resourceSize * UsesOptimizedAnimatedImages.getPercentSavings(record.resourceSize),
+        wastedBytes: record.resourceSize * EfficientAnimatedContent.getPercentSavings(record.resourceSize),
       };
     });
 
@@ -80,4 +80,4 @@ class UsesOptimizedAnimatedImages extends ByteEfficiencyAudit {
   }
 }
 
-module.exports = UsesOptimizedAnimatedImages;
+module.exports = EfficientAnimatedContent;
diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js
@@ -158,7 +158,7 @@ module.exports = {
     'byte-efficiency/uses-optimized-images',
     'byte-efficiency/uses-text-compression',
     'byte-efficiency/uses-responsive-images',
-    'byte-efficiency/uses-optimized-animated-images',
+    'byte-efficiency/efficient-animated-content',
     'dobetterweb/appcache-manifest',
     'dobetterweb/dom-size',
     'dobetterweb/external-anchors-use-rel-noopener',
@@ -283,7 +283,7 @@ module.exports = {
         {id: 'time-to-first-byte', weight: 0, group: 'perf-hint'},
         {id: 'redirects', weight: 0, group: 'perf-hint'},
         {id: 'uses-rel-preload', weight: 0, group: 'perf-hint'},
-        {id: 'uses-optimized-animated-images', weight: 0, group: 'perf-hint'},
+        {id: 'efficient-animated-content', weight: 0, group: 'perf-hint'},
         {id: 'total-byte-weight', weight: 0, group: 'perf-info'},
         {id: 'uses-long-cache-ttl', weight: 0, group: 'perf-info'},
         {id: 'dom-size', weight: 0, group: 'perf-info'},

diff --git a/...cy/uses-optimized-animated-images-test.js → ...ciency/efficient-animated-content-test.js b/...cy/uses-optimized-animated-images-test.js → ...ciency/efficient-animated-content-test.js
@@ -6,8 +6,8 @@
 'use strict';
 
 /* eslint-env mocha */
-const UsesOptimizedAnimatedImages =
-  require('../../../audits/byte-efficiency/uses-optimized-animated-images');
+const EfficientAnimatedContent =
+  require('../../../audits/byte-efficiency/efficient-animated-content');
 const WebInspector = require('../../../lib/web-inspector');
 const assert = require('assert');
 
@@ -28,11 +28,11 @@ describe('Page uses videos for animated GIFs', () => {
       },
     ];
     const artifacts = {
-      devtoolsLogs: {[UsesOptimizedAnimatedImages.DEFAULT_PASS]: []},
+      devtoolsLogs: {[EfficientAnimatedContent.DEFAULT_PASS]: []},
       requestNetworkRecords: () => Promise.resolve(networkRecords),
     };
 
-    const {results} = await UsesOptimizedAnimatedImages.audit_(artifacts);
+    const {results} = await EfficientAnimatedContent.audit_(artifacts);
     assert.equal(results.length, 1);
     assert.equal(results[0].url, 'https://example.com/example2.gif');
     assert.equal(results[0].totalBytes, 110000);
@@ -48,11 +48,11 @@ describe('Page uses videos for animated GIFs', () => {
       },
     ];
     const artifacts = {
-      devtoolsLogs: {[UsesOptimizedAnimatedImages.DEFAULT_PASS]: []},
+      devtoolsLogs: {[EfficientAnimatedContent.DEFAULT_PASS]: []},
       requestNetworkRecords: () => Promise.resolve(networkRecords),
     };
 
-    const {results} = await UsesOptimizedAnimatedImages.audit_(artifacts);
+    const {results} = await EfficientAnimatedContent.audit_(artifacts);
     assert.equal(results.length, 0);
   });
 
@@ -70,11 +70,11 @@ describe('Page uses videos for animated GIFs', () => {
       },
     ];
     const artifacts = {
-      devtoolsLogs: {[UsesOptimizedAnimatedImages.DEFAULT_PASS]: []},
+      devtoolsLogs: {[EfficientAnimatedContent.DEFAULT_PASS]: []},
       requestNetworkRecords: () => Promise.resolve(networkRecords),
     };
 
-    const {results} = await UsesOptimizedAnimatedImages.audit_(artifacts);
+    const {results} = await EfficientAnimatedContent.audit_(artifacts);
     assert.equal(results.length, 0);
   });
 });