extension(popup): keep feedback class (#5872)

GoogleChrome · Aug 21, 2018 · 1bd8b5e · 1bd8b5e
1 parent 79a9a5f
commit 1bd8b5e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/lighthouse-extension/app/src/popup.js b/lighthouse-extension/app/src/popup.js
@@ -154,11 +154,14 @@ async function onGenerateReportButtonClick(background, settings) {
   }
   isRunning = true;
 
+  // resetting status message
+  const statusMsg = find('.status__msg');
+  statusMsg.textContent = 'Starting...';
+
   showRunningSubpage();
 
   const feedbackEl = find('.feedback');
   feedbackEl.textContent = '';
-
   const {selectedCategories, useDevTools} = settings;
   /** @type {LH.Flags} */
   const flags = {throttlingMethod: useDevTools ? 'devtools' : 'simulate'};
@@ -185,7 +188,7 @@ async function onGenerateReportButtonClick(background, settings) {
     feedbackEl.textContent = message;
 
     if (includeReportLink) {
-      feedbackEl.className = 'feedback-error';
+      feedbackEl.className = 'feedback feedback-error';
       feedbackEl.appendChild(buildReportErrorLink(err));
     }
 

diff --git a/lighthouse-extension/app/styles/lighthouse.css b/lighthouse-extension/app/styles/lighthouse.css
@@ -188,20 +188,14 @@ html, body {
   position: absolute;
   color: #fff;
   bottom: 10px;
-  left: 16px;
+  left: 14px; /* 16px - 2px of shadow from the options button */
   width: 180px;
   line-height: 1.45;
 }
 
 .feedback-error {
-  background-color: var(--lh-blue-color);
-  position: absolute;
-  color: #fff;
-  bottom: 10px;
-  left: 16px;
-  width: 180px;
-  line-height: 1.45;
   font-size: .9em;
+  min-height: 38px;
 }
 
 /* 1. scrollbar when extension is too small */